[
https://issues.apache.org/jira/browse/DISPATCH-2370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17913015#comment-17913015
]
ASF GitHub Bot commented on DISPATCH-2370:
------------------------------------------
gemmellr commented on code in PR #1741:
URL: https://github.com/apache/qpid-dispatch/pull/1741#discussion_r1915349523
##########
packaging/README.adoc:
##########
@@ -0,0 +1,39 @@
+////
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License
+////
+
+= Packaging
+
+== rpm
+
+The https://packit.dev/docs/cli[`packit` tool] expects to have a
`.packit.yaml` file at the source root.
+
+.Example: install build dependencies
+[source,shell script]
+----
+dnf install 'dnf-command(builddep)'
+dnf builddep -y packaging/skupper-router.spec
Review Comment:
Seems questionable
##########
.packit.yaml:
##########
@@ -0,0 +1,40 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+# See the documentation for more information:
+# https://packit.dev/docs/configuration/
+
+# https://packit.dev/docs/configuration/#top-level-keys
+upstream_project_url: https://qpid.apache.org/components/dispatch-router
+issue_repository: https://issues.apache.org/jira/projects/DISPATCH/issues
+
+specfile_path: packaging/qpid-dispatch.spec
Review Comment:
If this is aimed at testing changes with fedora-rawhide then the structure
should perhaps convey that rather than simply using a root of 'packaging' ?
##########
packaging/dispatch.patch:
##########
@@ -0,0 +1,30 @@
+diff --git a/etc/qdrouterd.conf b/etc/qdrouterd.conf
+index 4e8e506c..add40c69 100644
+-
> Configure "Packit-as-a-Service" application for
> github.com/apache/qpid-dispatch
> -------------------------------------------------------------------------------
>
> Key: DISPATCH-2370
> URL: https://issues.apache.org/jira/browse/DISPATCH-2370
> Project: Qpid Dispatch
> Issue Type: Bug
> Affects Versions: 1.19.0
> Reporter: Jiri Daněk
> Assignee: Jiri Daněk
> Priority: Major
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
