astitcher commented on code in PR #434: URL: https://github.com/apache/qpid-proton/pull/434#discussion_r1761602319
########## c/src/core/transport.c: ########## @@ -2828,6 +2861,8 @@ uint32_t pn_transport_get_max_frame(pn_transport_t *transport) void pn_transport_set_max_frame(pn_transport_t *transport, uint32_t size) { // if size == 0, no advertised limit to input frame size. + if (transport->open_sent) + return; // Too late. Silently disregard request. Review Comment: Instead of silently disregarding the request it's probably better to log a warning. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org