[
https://issues.apache.org/jira/browse/PROTON-2355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17874595#comment-17874595
]
ASF GitHub Bot commented on PROTON-2355:
----------------------------------------
codecov-commenter commented on PR #302:
URL: https://github.com/apache/qpid-proton/pull/302#issuecomment-2295043229
##
[Codecov](https://app.codecov.io/gh/apache/qpid-proton/pull/302?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 69.02%. Comparing base
[(`5d3473d`)](https://app.codecov.io/gh/apache/qpid-proton/commit/5d3473dd484090590863c0d87dea4ea91bba87dc?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
to head
[(`3a23b4e`)](https://app.codecov.io/gh/apache/qpid-proton/commit/3a23b4eff6bdf40ac224f74a4768b3277e59f912?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 380 commits behind head on main.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #302 +/- ##
==========================================
- Coverage 69.04% 69.02% -0.03%
==========================================
Files 353 353
Lines 69480 69479 -1
==========================================
- Hits 47973 47958 -15
- Misses 21507 21521 +14
```
</details>
[:umbrella: View full report in Codecov by
Sentry](https://app.codecov.io/gh/apache/qpid-proton/pull/302?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it
here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Build failure with -DPROACTOR=none
> ----------------------------------
>
> Key: PROTON-2355
> URL: https://issues.apache.org/jira/browse/PROTON-2355
> Project: Qpid Proton
> Issue Type: Bug
> Components: build
> Affects Versions: proton-c-0.33.0
> Reporter: Fabrice Fontaine
> Assignee: Jiri Daněk
> Priority: Major
> Fix For: proton-c-0.34.0
>
> Attachments: 0001-Fix-build-with-DPROACTOR-none.patch
>
>
> Building with -DPROACTOR=none fails on:
> {code:java}
> CMake Error at c/CMakeLists.txt:481 (add_library):
> Error evaluating generator expression:
> $<TARGET_OBJECTS:qpid-proton-proactor-objects>
> Objects of target "qpid-proton-proactor-objects" referenced but no such
> target exists.
> {code}
> It should also be noted that libqpid-proton-cpp also assumes that a proactor
> is always available (e.g. pn_connection_wake is unconditionally used in
> ./cpp/src/connection.cpp).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
