[
https://issues.apache.org/jira/browse/PROTON-2818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17839863#comment-17839863
]
ASF GitHub Bot commented on PROTON-2818:
----------------------------------------
astitcher commented on code in PR #427:
URL: https://github.com/apache/qpid-proton/pull/427#discussion_r1575387644
##########
c/src/proactor/epoll.c:
##########
@@ -1139,6 +1141,21 @@ static pn_event_batch_t
*pconnection_process(pconnection_t *pc, uint32_t events,
}
if (sched_ready) schedule_done(&pc->task);
+ if (pc->first_schedule) {
+ // Normal case: resumed logic from pn_proactor_connect2.
+ // But possible tie: pn_connection_wake() or pn_proactor_disconnect().
Review Comment:
type? "possibility of"?
##########
c/src/proactor/epoll.c:
##########
@@ -1139,6 +1141,21 @@ static pn_event_batch_t
*pconnection_process(pconnection_t *pc, uint32_t events,
}
if (sched_ready) schedule_done(&pc->task);
+ if (pc->first_schedule) {
+ // Normal case: resumed logic from pn_proactor_connect2.
+ // But possible tie: pn_connection_wake() or pn_proactor_disconnect().
Review Comment:
typo? "possibility of"?
> Move epoll proctor connection logic to a task thread
> ----------------------------------------------------
>
> Key: PROTON-2818
> URL: https://issues.apache.org/jira/browse/PROTON-2818
> Project: Qpid Proton
> Issue Type: Bug
> Components: proton-c
> Affects Versions: proton-c-0.39.0
> Reporter: Clifford Jansen
> Assignee: Clifford Jansen
> Priority: Major
>
> See PROTON-2812. Implement the first described mitigation.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
