dakirily commented on code in PR #238:
URL: https://github.com/apache/qpid-broker-j/pull/238#discussion_r1478308423
##########
broker-core/src/test/java/org/apache/qpid/server/store/BrokerStoreUpgraderAndRecovererTest.java:
##########
@@ -121,9 +124,10 @@ public void
testUpgradeVirtualHostWithJDBCStoreAndHikariCPPool()
"qpid.jdbcstore.varBinaryType", "myvarbinary",
"qpid.jdbcstore.blobType", "myblob",
"qpid.jdbcstore.useBytesForBlob", true,
- "qpid.jdbcstore.hikaricp.maximumPoolSize", 7,
- "qpid.jdbcstore.hikaricp.minimumIdle", 6);
- final Map<String,Object> expectedAttributes =
Map.of("connectionPoolType", "HIKARICP",
+ "qpid.jdbcstore.bonecp.maxConnectionsPerPartition", 7,
+ "qpid.jdbcstore.bonecp.minConnectionsPerPartition", 6,
+ "qpid.jdbcstore.bonecp.partitionCount", 2);
+ final Map<String,Object> expectedAttributes =
Map.of("connectionPoolType", "BONECP",
Review Comment:
Hi Robbie,
[PR-239](https://github.com/apache/qpid-broker-j/pull/239) was created to
fix those issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
