[
https://issues.apache.org/jira/browse/QPID-8666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17813699#comment-17813699
]
ASF GitHub Bot commented on QPID-8666:
--------------------------------------
gemmellr commented on code in PR #238:
URL: https://github.com/apache/qpid-broker-j/pull/238#discussion_r1476106471
##########
broker-core/src/test/java/org/apache/qpid/server/store/BrokerStoreUpgraderAndRecovererTest.java:
##########
@@ -121,9 +124,10 @@ public void
testUpgradeVirtualHostWithJDBCStoreAndHikariCPPool()
"qpid.jdbcstore.varBinaryType", "myvarbinary",
"qpid.jdbcstore.blobType", "myblob",
"qpid.jdbcstore.useBytesForBlob", true,
- "qpid.jdbcstore.hikaricp.maximumPoolSize", 7,
- "qpid.jdbcstore.hikaricp.minimumIdle", 6);
- final Map<String,Object> expectedAttributes =
Map.of("connectionPoolType", "HIKARICP",
+ "qpid.jdbcstore.bonecp.maxConnectionsPerPartition", 7,
+ "qpid.jdbcstore.bonecp.minConnectionsPerPartition", 6,
+ "qpid.jdbcstore.bonecp.partitionCount", 2);
+ final Map<String,Object> expectedAttributes =
Map.of("connectionPoolType", "BONECP",
Review Comment:
Doesnt the fact these bits of the output didnt change (now restored to their
previous/original values), even though the updater is meant to be handling
transition from bonecp to hikaricp pool, suggest that not everything that
should be upgraded is being so?
EDIT: so this test is checking for "VirtualHostNode" context, whereas the
updater is only covering "VirtualHost" context entries, which seems likely to
explain things. Given both can apparently separately be using JDBC and thus
pooling (even if I dont see a point for the node) it feels like both should be
covered.
EDIT2: Actually, can the broker have this context config as well? to be
defined in one place and inherited by the rest if they use it and not override?
> [Broker-J] Broker plugin jdbc-provider-bone replacement
> -------------------------------------------------------
>
> Key: QPID-8666
> URL: https://issues.apache.org/jira/browse/QPID-8666
> Project: Qpid
> Issue Type: Improvement
> Components: Broker-J
> Affects Versions: qpid-java-broker-9.1.0
> Reporter: Daniil Kirilyuk
> Priority: Major
> Fix For: qpid-java-broker-9.2.0
>
>
> Broker plugin jdbc-provider-bone relies on JDBC connection pooling library
> bonecp, which is no longer developed or updated. The [github project
> page|https://github.com/wwadge/bonecp] states:
> "BoneCP is a Java JDBC connection pool implementation that is tuned for high
> performance by minimizing lock contention to give greater throughput for your
> applications. It beats older connection pools such as C3P0 and DBCP but
> should now be considered deprecated in favour of HikariCP".
> Plugin jdbc-provider-bone should be replaced with the new one
> jdbc-provider-hikaricp based on
> [HikariCP|https://github.com/brettwooldridge/HikariCP] library. Both
> libraries use Apache-2.0 license.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
