[ 
https://issues.apache.org/jira/browse/PROTON-2438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17607922#comment-17607922
 ] 

ASF GitHub Bot commented on PROTON-2438:
----------------------------------------

codecov-commenter commented on PR #379:
URL: https://github.com/apache/qpid-proton/pull/379#issuecomment-1254040995

   # 
[Codecov](https://codecov.io/gh/apache/qpid-proton/pull/379?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 Report
   > Merging 
[#379](https://codecov.io/gh/apache/qpid-proton/pull/379?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 (3930f09) into 
[main](https://codecov.io/gh/apache/qpid-proton/commit/a4375a8351c3435bd5025bb2481307efe97dc99e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 (a4375a8) will **decrease** coverage by `18.68%`.
   > The diff coverage is `71.42%`.
   
   ```diff
   @@             Coverage Diff             @@
   ##             main     #379       +/-   ##
   ===========================================
   - Coverage   88.34%   69.66%   -18.69%     
   ===========================================
     Files          47      368      +321     
     Lines        2394    71522    +69128     
   ===========================================
   + Hits         2115    49824    +47709     
   - Misses        279    21698    +21419     
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/qpid-proton/pull/379?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 | Coverage Δ | |
   |---|---|---|
   | 
[cpp/include/proton/container.hpp](https://codecov.io/gh/apache/qpid-proton/pull/379/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y3BwL2luY2x1ZGUvcHJvdG9uL2NvbnRhaW5lci5ocHA=)
 | `100.00% <ø> (ø)` | |
   | 
[cpp/include/proton/work\_queue.hpp](https://codecov.io/gh/apache/qpid-proton/pull/379/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y3BwL2luY2x1ZGUvcHJvdG9uL3dvcmtfcXVldWUuaHBw)
 | `57.14% <ø> (ø)` | |
   | 
[cpp/src/proactor\_container\_impl.hpp](https://codecov.io/gh/apache/qpid-proton/pull/379/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y3BwL3NyYy9wcm9hY3Rvcl9jb250YWluZXJfaW1wbC5ocHA=)
 | `72.72% <ø> (ø)` | |
   | 
[cpp/src/container.cpp](https://codecov.io/gh/apache/qpid-proton/pull/379/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y3BwL3NyYy9jb250YWluZXIuY3Bw)
 | `73.07% <33.33%> (ø)` | |
   | 
[cpp/src/proactor\_container\_impl.cpp](https://codecov.io/gh/apache/qpid-proton/pull/379/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y3BwL3NyYy9wcm9hY3Rvcl9jb250YWluZXJfaW1wbC5jcHA=)
 | `87.70% <81.81%> (ø)` | |
   | 
[c/src/reactor/connection.c](https://codecov.io/gh/apache/qpid-proton/pull/379/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Yy9zcmMvcmVhY3Rvci9jb25uZWN0aW9uLmM=)
 | `68.86% <0.00%> (ø)` | |
   | 
[cpp/src/reconnect\_options\_impl.hpp](https://codecov.io/gh/apache/qpid-proton/pull/379/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y3BwL3NyYy9yZWNvbm5lY3Rfb3B0aW9uc19pbXBsLmhwcA==)
 | `100.00% <0.00%> (ø)` | |
   | 
[python/proton/reactor.py](https://codecov.io/gh/apache/qpid-proton/pull/379/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHl0aG9uL3Byb3Rvbi9yZWFjdG9yLnB5)
 | `100.00% <0.00%> (ø)` | |
   | 
[python/tests/proton\_tests/engine.py](https://codecov.io/gh/apache/qpid-proton/pull/379/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHl0aG9uL3Rlc3RzL3Byb3Rvbl90ZXN0cy9lbmdpbmUucHk=)
 | `98.61% <0.00%> (ø)` | |
   | 
[c/src/core/util.c](https://codecov.io/gh/apache/qpid-proton/pull/379/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Yy9zcmMvY29yZS91dGlsLmM=)
 | `79.10% <0.00%> (ø)` | |
   | ... and [316 
more](https://codecov.io/gh/apache/qpid-proton/pull/379/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 | |
   
   :mega: We’re building smart automated test selection to slash your CI/CD 
build times. [Learn 
more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   




> [cpp] Cancellable tasks
> -----------------------
>
>                 Key: PROTON-2438
>                 URL: https://issues.apache.org/jira/browse/PROTON-2438
>             Project: Qpid Proton
>          Issue Type: Improvement
>          Components: cpp-binding
>            Reporter: Božo Dragojevič
>            Assignee: Justin Ross
>            Priority: Major
>
> Allow scheduled tasks to be cancelled.
> A cancelled task does not keep reactor from stoping running



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

Reply via email to