Adding the Netty deps licenses, but I don't think we need to report the ASL license in our NOTICE. The license for Netty is anyway reported in our LICENSE file.
On Tue, May 8, 2018 at 10:24 AM Ivan Kelly <iv...@apache.org> wrote: > > Created PR at https://github.com/apache/incubator-pulsar/pull/1748 > > I'll take a look, but it may be tomorrow before I get the time. > > > In some cases, the feedback for the NOTICE file has been to avoid > inclusion > > on what was not strictly required, in particular, regarding non ASL > > licensed projects. Another example was around Netty NOTICE file which was > > originally bubbled up and then we removed it after feedback. > > Netty is a strange case, because they put far too much in their notice > file. However, if there is something in the netty notice file which > refers to ASLv2 code which has been included in the netty source, and > a binary object based on that code is shipped with pulsar, then that > should be bubbled up from the netty code. As far as I can tell (and > assuming the case is the same as for bookkeeper), the part of the > netty notice which should be bubbled up to pulsar notice is: > > <snip> > The Netty Project > ================= > > Please visit the Netty web site for more information: > > * http://netty.io/ > > Copyright 2014 The Netty Project > > The Netty Project licenses this file to you under the Apache License, > version 2.0 (the "License"); you may not use this file except in compliance > with the License. You may obtain a copy of the License at: > > http://www.apache.org/licenses/LICENSE-2.0 > > Unless required by applicable law or agreed to in writing, software > distributed under the License is distributed on an "AS IS" BASIS, WITHOUT > WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the > License for the specific language governing permissions and limitations > under the License. > </snip> > > There is other code, which netty integrates into its code, but which > is MIT/BSD license. These should be notes in the LICENSE. > See > https://github.com/apache/bookkeeper/blob/master/bookkeeper-dist/src/main/resources/LICENSE-all.bin.txt#L368-L416 > > -Ivan > -- Matteo Merli <mme...@apache.org>
