+1 (binding) (replaces my previous vote) - verified source release file hash and signature - ran build - validated the Nuget package using a simple Pulsar app
Using dotnet sdk 9.0.100 (dotnet --version) on MacOS arm64. Used the documented validation process on MacOS: https://github.com/apache/pulsar-dotpulsar/blob/master/docs/release_validation_linux_macos.md > Validation Instructions: According to Homebrew’s formula page, .NET 9.0 > appears to be the new default. Thanks, I ran "brew upgrade" and the package got upgraded to 9.0.100 so I was able to complete the validation. It wasn't available 2 days ago when I previously attempted to do the validation. -Lari On Fri, 15 Nov 2024 at 11:21, David Jensen <djen...@apache.org> wrote: > > Hi Lari, > > Thank you for your feedback and for raising these important points. > > Target Frameworks: The release targets .NET Standard 2.0, which ensures > compatibility with multiple .NET versions, including .NET 6.0, 7.0, 8.0, and > 9.0. You can review the documentation > https://learn.microsoft.com/en-us/dotnet/standard/net-standard?tabs=net-standard-2-0 > and inspect the NuGet package > https://nuget.info/packages/DotPulsar/3.5.0-rc.1. We decided to include .NET > 9.0 to leverage its latest features and improvements while maintaining > compatibility with older versions through .NET Standard 2.0. > > Reason for Including .NET 9.0: The decision to include .NET 9.0 was driven by > its recent release and the significant performance and security enhancements > it offers. We believe adopting .NET 9.0 will provide a better experience for > our users. > > Validation Instructions: According to Homebrew’s formula page, .NET 9.0 > appears to be the new default. However, I don’t have access to a Mac to > confirm this directly. > https://formulae.brew.sh/cask/dotnet-sdk#default > > I appreciate your patience and understanding. I hope these clarifications > address your concerns and look forward to your reconsideration of the vote. > > Best regards, > David > > On 2024/11/13 14:42:08 Lari Hotari wrote: > > -1 (binding) > > > > Thanks for driving the release, David. > > > > This release switches to .NET 9.0 and that needs more explanation. > > - Does the release also target .NET 8.0 or did we switch to .NET 9.0 > > as the only target? > > - Is there a specific reason to switch the target to .NET 9.0? .NET > > 9.0.0 was released yesterday, on November 12th, 2024. > > > > The release validation instructions for Linux and MacOS fail since > > .NET 8.0.x continues to be the default for homebrew. That would need > > to be addressed so that the release could be validated. > > > > I'll reconsider my vote after there are answers for these questions. > > > > -Lari > > > > On Wed, 13 Nov 2024 at 13:51, David Jensen <djen...@apache.org> wrote: > > > > > > Hi everyone, > > > > > > Please review and vote on the release candidate for the version 3.5.0, as > > > follows: > > > > > > [ ] +1, Approve the release > > > [ ] -1, Do not approve the release (please provide specific comments) > > > > > > DotPulsar's KEYS file contains the PGP keys we used to sign this release: > > > https://downloads.apache.org/pulsar/KEYS > > > > > > Please download these packages and review this release candidate: > > > - Review release notes > > > - Download the source package (verify shasum, and asc) and follow the > > > README.md to build and run DotPulsar. > > > > > > The vote will be open for at least 72 hours. It is adopted by majority > > > approval, with at least 3 PMC affirmative votes. > > > > > > Guide for Validating DotPulsar Release on Linux and MacOS > > > https://github.com/apache/pulsar-dotpulsar/blob/master/docs/release_validation_linux_macos.md > > > > > > Source file: > > > https://dist.apache.org/repos/dist/dev/pulsar/pulsar-dotpulsar-3.5.0-rc.1/ > > > > > > Nuget package: > > > https://www.nuget.org/packages/DotPulsar/3.5.0-rc.1 > > > > > > The tag to be voted upon: > > > https://github.com/apache/pulsar-dotpulsar/tree/3.5.0-rc.1 > > > > > > SHA-512 checksums: > > > 98a0aa571e6f39127a40d35ce9cc8afe781040e464984270ffaced5edc6d8ac2a154c500521126254a4689540e40f1245d71bfd76691828a2d08f0f72a9fbcc7 > > > pulsar-dotpulsar-3.5.0-src.tar.gz > >
