+1 to the upgrade The only problem is for any broker plugin that registers a Servlet, so we cannot cherry-pick this change to preview release lines
Enrico Il giorno mer 8 mag 2024 alle ore 22:05 Lari Hotari <lhot...@apache.org> ha scritto: > Targeting 3.4.x/4.0.x for Jetty 12 upgrade. > Here's the WIP: > https://github.com/apache/pulsar/compare/master...lhotari:pulsar:lh-jetty-12 > > The world moves on and there's not really an option to stay on Jetty 9.x > for any longer as I have explained in the previous email. > > One of the breaking changes will be > org.apache.pulsar.broker.web.plugin.servlet.AdditionalServlet which isn't a > great interface. it contains a Jetty specific return type in method > "getServletHolder". This will break in the Jetty 12 upgrade. > javax.servlet.Servlet / jakarta.servlet.Servlet are support by Jetty 12 and > it's completely unnecessary to have a Jetty specific return type in the > AdditionalServlet interface. > > -Lari > > On 2024/04/17 13:57:16 Lari Hotari wrote: > > Hi, > > > > Pulsar Broker and Pulsar Proxy use Jetty 9.4.x. Jetty 9.4.x has reached > end-of-line already in June 2022. Jetty 9.4.x has been receiving security > updates until now although it is not officially supported anymore. This > might change soon. That's why we need to start preparing to upgrade to > Jetty 12. > > > > It is recommended to skip Jetty 10 and Jetty 11 since they are also end > of support. > > More details about this recommendation is in this Jetty GitHub issue > message by the Jetty maintainer: > https://github.com/jetty/jetty.project/issues/11644#issuecomment-2048516903 > . > > > > Could we target Jetty 12 upgrade for the master branch so that it gets > included in Pulsar 3.3.x ? > > Or, do we first release 3.3.x asap and then tackle this upgrade for > Pulsar 3.4.x? > > > > -Lari > > >
