Hi Xiangying I think before we cherry-pick this PR, we should check why it introduced a Flaky test https://github.com/apache/pulsar/issues/22351, we need to confirm whether this raises other issues.
Thanks Yubiao Feng On Sun, Apr 7, 2024 at 7:13 PM Xiangying Meng <xiangy...@apache.org> wrote: > Hi all, > > I want to start a discussion to cherry-pick #22034 [0] to release branches. > The PR creates a new ledger after the current one is full. This is a > bug fix to resolve the issue where the last ledger could not be > deleted after expiration. Moreover, since there is no need to create a > new ledger only when messages are sent, it can reduce the send > latency. > > However, it could be a behavior change and introduce some flaky tests > we have fixed in the master. So I think it may be necessary to have a > discussion before cherry-picking. > > The target branches: > > - branch-3.0 > - branch-3.1 > - branch-3.2 > > [0] https://github.com/apache/pulsar/pull/22034 > > I will keep the discussion open for at least 48 hours. > If there is no objections, I will perform the cherry-picking. > > BR, > Xiangying >
