Hi Lari, I will build the new candidate-4 soon. Regards Jiwei Guo (Tboy)
On Mon, Jan 22, 2024 at 5:02 AM Lari Hotari <lhot...@apache.org> wrote: > Thank you for reviewing and merging the PR #21937 (restoring the broker id > format). I have cherry-picked that to branch-3.2 together with it's > dependency PR #21894 (fixes leader broker election when advertised > listeners is configured) and in addition #21871 (pulsar-bom). > > From my side we are ready for the next release candidate. > > Thank you, Jiwei Guo (Tboy), for driving the release and handling all of > the extra work related to the multiple RCs. > > -Lari > > On 2024/01/20 16:46:23 Lari Hotari wrote: > > As a follow up, I have created > https://github.com/apache/pulsar/pull/21937 to restore the broker id > (previously called "lookup service address") to match the format used in > existing Pulsar releases. > > > > There was a misconception that PR #17136 would have changed the broker > id ("lookup service address") format in Pulsar 2.11 release. That PR didn't > change the format. It can be verified from the diff [1]. > > > > Please review the PR https://github.com/apache/pulsar/pull/21937. After > merging, I suggest that we cherry-pick it to branch-3.2 together with the > fix for the advertised listeners bug related to broker id [2]. > > > > Since we need yet another RC for 3.2.0, let's consider adding the BOM > support (PIP-326) to 3.2.0 release as suggested by Chris Bono in another > thread. [3] > > > > -Lari > > > > 1 - https://github.com/apache/pulsar/pull/17136/files > > 2 - https://github.com/apache/pulsar/pull/21894 > > 3 - https://lists.apache.org/thread/9vqgwpqxjo04n1pyzg0s00nrb3sl8r07 > > > > On 2024/01/19 19:55:10 Lari Hotari wrote: > > > -1 from my side. > > > > > > Explanation: I didn't notice until now that the "lookup service > address" (now brokerId ) was modified for 3.2.0 in this PR > https://github.com/apache/pulsar/pull/21015 based on this issue report > https://github.com/apache/pulsar/issues/21012 . > > > > > > I'm waiting for answers on the question in 21012 so that I could > understand the reason why this was considered a problem in the first place. > > > > > > The "lookup service address" was never meant to be used as a "service > address" for the broker and this confusion was addressed recently by > https://github.com/apache/pulsar/pull/21894 . "lookup service address" > was renamed to "broker id" which hopefully clarifies that it's just an > unique runtime identifier for the broker (which is used in Pulsar load > manager to as the broker's unique id). > > > > > > I'll follow-up asap on this after receiving answers. > > > > > > -Lari > > > > > > > > > On 2024/01/19 07:49:11 guo jiwei wrote: > > > > This is the third release candidate for Apache Pulsar version 3.2.0. > > > > > > > > It fixes the following issues: > > > > https://github.com/apache/pulsar/milestone/36?closed=1 > > > > > > > > *** Please download, test and verify on this release. This release > > > > candidate verification will stay open until Jan 25 *** > > > > > > > > Note that we are verifying upon the source (tag), binaries are > provided for > > > > convenience. > > > > > > > > Source and binary files: > > > > > https://dist.apache.org/repos/dist/dev/pulsar/pulsar-3.2.0-candidate-3/ > > > > > > > > SHA-512 checksums: > > > > > > > > > 27e70dfa4e1fd6b300f92463c6ef3165dcf02ac2f933199bf9f1e29693d538a1012e950ad3a1195833275504b0924623d068d70e4eefca0cf2819dfc6b2cd698 > > > > > > > > apache-pulsar-3.2.0-bin.tar.gz > > > > > > > > > 9d4c889889a920a133a7a07035dbd2cfc61b63aa112b072ea6138aad228358cbbc04c71953839321cf9896458aed18965fb15b547e8890969e95bf3426134470 > > > > > > > > apache-pulsar-3.2.0-src.tar.gz > > > > > > > > Maven staging repo: > > > > > https://repository.apache.org/content/repositories/orgapachepulsar-1263/ > > > > > > > > The tag to verify: > > > > v3.2.0-candidate-3 (9630608ff1fd726cbd124a2e65a1a50c3802b5dc) > > > > https://github.com/apache/pulsar/commits/v3.2.0-candidate-3/ > > > > > > > > Pulsar's KEYS file containing PGP keys you use to sign the release: > > > > https://dist.apache.org/repos/dist/dev/pulsar/KEYS > > > > > > > > Docker images: > > > > > > > > pulsar images: > > > > > https://hub.docker.com/layers/technoboy8/pulsar/3.2.0-9630608/images/sha256-ab30ee3fcde4667072d864cb82d774fe90cdd1d8e4b8ed70b44a97aa292ea826?context=repo > > > > < > https://hub.docker.com/layers/mattison/pulsar/3.1.0-candidate-1/images/sha256-0efbaad7d893cc5041a46a2d4d56432bda855ae4068a38349777d1be6e98d27d?context=explore > > > > > > pulsar-all images: > > > > > https://hub.docker.com/layers/technoboy8/pulsar-all/3.2.0-9630608/images/sha256-48fccc356637961402627ccbf900f8ea08cf1c325a32d2ea32660a3f4d7a365b?context=repo > > > > > > > > Please download the source package, and follow the README to build > > > > and run the Pulsar standalone service. > > > > > > > > Note that this RC doesn't require a formal vote, but we would also > > > > appreciate your feedback with +1/-1. And please provide specific > > > > comments if your feedback is not +1. > > > > > > > > > > > > > > > > Regards > > > > Jiwei Guo (Tboy) > > > > > > > > > >
