+1 (binding)

- verified signatures are valid on 2 artifacts
- verified checksums are correct on 2 artifacts
- verified `helm gpg verify pulsar-3.1.0.tgz`
- verified the licenses and notice with `java -jar
/apache-rat-0.15/apache-rat-0.15.jar . -E .rat-excludes`. I noticed
that Lari had trouble, so I'm not sure what I did differently. I
include the script's output at the end of this email.
- reviewed commit log since previous release

I am not able to test the helm chart, but that isn't strictly required
for release validation, so I am going to skip that for now, and we can
address any bugs discovered later.

Thanks for running the release, Lari.

- Michael

$  java -jar ~/apache-rat-0.15/apache-rat-0.15.jar . -E .rat-excludes
Ignored 18 lines in your exclusion files as comments or empty lines.

*****************************************************
Summary
-------
Generated at: 2023-12-21T00:10:16-06:00

Notes: 4
Binaries: 0
Archives: 0
Standards: 94

Apache Licensed: 94
Generated Documents: 0

JavaDocs are generated, thus a license header is optional.
Generated files do not require license headers.

0 Unknown Licenses

*****************************************************
  Files with Apache License headers will be marked AL
  Binary files (which do not require any license headers) will be marked B
  Compressed archives will be marked A
  Notices, licenses etc. will be marked N
  AL    ./.asf.yaml
  AL    ./.rat-excludes
  N     ./LICENSE
  N     ./NOTICE
  AL    ./README.md
  AL    ./RELEASE.md
  AL    ./Vagrantfile
  AL    ./license_test.go
  AL    ./charts/pulsar/.helmignore
  AL    ./charts/pulsar/Chart.yaml
  N     ./charts/pulsar/LICENSE
  N     ./charts/pulsar/NOTICE
  AL    ./charts/pulsar/values.yaml
  AL    ./charts/pulsar/templates/_autorecovery.tpl
  AL    ./charts/pulsar/templates/_bookkeeper.tpl
  AL    ./charts/pulsar/templates/_broker.tpl
  AL    ./charts/pulsar/templates/_configurationstore.tpl
  AL    ./charts/pulsar/templates/_helpers.tpl
  AL    ./charts/pulsar/templates/_toolset.tpl
  AL    ./charts/pulsar/templates/_zookeeper.tpl
  AL    ./charts/pulsar/templates/autorecovery-configmap.yaml
  AL    ./charts/pulsar/templates/autorecovery-podmonitor.yaml
  AL    ./charts/pulsar/templates/autorecovery-rbac.yaml
  AL    ./charts/pulsar/templates/autorecovery-service.yaml
  AL    ./charts/pulsar/templates/autorecovery-statefulset.yaml
  AL    ./charts/pulsar/templates/bookkeeper-cluster-initialize.yaml
  AL    ./charts/pulsar/templates/bookkeeper-configmap.yaml
  AL    ./charts/pulsar/templates/bookkeeper-pdb.yaml
  AL    ./charts/pulsar/templates/bookkeeper-podmonitor.yaml
  AL    ./charts/pulsar/templates/bookkeeper-rbac.yaml
  AL    ./charts/pulsar/templates/bookkeeper-service.yaml
  AL    ./charts/pulsar/templates/bookkeeper-statefulset.yaml
  AL    ./charts/pulsar/templates/bookkeeper-storageclass.yaml
  AL    ./charts/pulsar/templates/broker-cluster-role-binding.yaml
  AL    ./charts/pulsar/templates/broker-configmap.yaml
  AL    ./charts/pulsar/templates/broker-hpa.yaml
  AL    ./charts/pulsar/templates/broker-pdb.yaml
  AL    ./charts/pulsar/templates/broker-podmonitor.yaml
  AL    ./charts/pulsar/templates/broker-rbac.yaml
  AL    ./charts/pulsar/templates/broker-service-account.yaml
  AL    ./charts/pulsar/templates/broker-service.yaml
  AL    ./charts/pulsar/templates/broker-statefulset.yaml
  AL    ./charts/pulsar/templates/dashboard-deployment.yaml
  AL    ./charts/pulsar/templates/dashboard-ingress.yaml
  AL    ./charts/pulsar/templates/dashboard-service.yaml
  AL    ./charts/pulsar/templates/function-worker-configmap.yaml
  AL    ./charts/pulsar/templates/keytool.yaml
  AL    ./charts/pulsar/templates/namespace.yaml
  AL    ./charts/pulsar/templates/proxy-configmap.yaml
  AL    ./charts/pulsar/templates/proxy-hpa.yaml
  AL    ./charts/pulsar/templates/proxy-ingress.yaml
  AL    ./charts/pulsar/templates/proxy-pdb.yaml
  AL    ./charts/pulsar/templates/proxy-podmonitor.yaml
  AL    ./charts/pulsar/templates/proxy-rbac.yaml
  AL    ./charts/pulsar/templates/proxy-service.yaml
  AL    ./charts/pulsar/templates/proxy-statefulset.yaml
  AL    ./charts/pulsar/templates/pulsar-cluster-initialize.yaml
  AL    ./charts/pulsar/templates/pulsar-manager-admin-secret.yaml
  AL    ./charts/pulsar/templates/pulsar-manager-configmap.yaml
  AL    ./charts/pulsar/templates/pulsar-manager-deployment.yaml
  AL    ./charts/pulsar/templates/pulsar-manager-ingress.yaml
  AL    ./charts/pulsar/templates/pulsar-manager-service.yaml
  AL    ./charts/pulsar/templates/tls-cert-internal-issuer.yaml
  AL    ./charts/pulsar/templates/tls-certs-internal.yaml
  AL    ./charts/pulsar/templates/toolset-configmap.yaml
  AL    ./charts/pulsar/templates/toolset-rbac.yaml
  AL    ./charts/pulsar/templates/toolset-service.yaml
  AL    ./charts/pulsar/templates/toolset-statefulset.yaml
  AL    ./charts/pulsar/templates/zookeeper-configmap.yaml
  AL    ./charts/pulsar/templates/zookeeper-pdb.yaml
  AL    ./charts/pulsar/templates/zookeeper-podmonitor.yaml
  AL    ./charts/pulsar/templates/zookeeper-rbac.yaml
  AL    ./charts/pulsar/templates/zookeeper-service.yaml
  AL    ./charts/pulsar/templates/zookeeper-statefulset.yaml
  AL    ./charts/pulsar/templates/zookeeper-storageclass.yaml
  AL    ./examples/values-bookkeeper-aws.yaml
  AL    ./examples/values-cs.yaml
  AL    ./examples/values-jwt-asymmetric.yaml
  AL    ./examples/values-jwt-symmetric.yaml
  AL    ./examples/values-local-cluster.yaml
  AL    ./examples/values-local-pv.yaml
  AL    ./examples/values-minikube.yaml
  AL    ./examples/values-no-persistence.yaml
  AL    ./examples/values-one-node.yaml
  AL    ./examples/values-tls.yaml
  AL    ./examples/values-zookeeper-aws.yaml
  AL    ./hack/common.sh
  AL    ./hack/kind-cluster-build.sh
  AL    ./scripts/set-pulsar-version.sh
  AL    ./scripts/sign.sh
  AL    ./scripts/cert-manager/install-cert-manager.sh
  AL    ./scripts/pulsar/cleanup_helm_release.sh
  AL    ./scripts/pulsar/common.sh
  AL    ./scripts/pulsar/common_auth.sh
  AL    ./scripts/pulsar/generate_token.sh
  AL    ./scripts/pulsar/generate_token_secret_key.sh
  AL    ./scripts/pulsar/get_token.sh
  AL    ./scripts/pulsar/prepare_helm_release.sh

*****************************************************

On Wed, Dec 20, 2023 at 3:01 AM PengHui Li <peng...@apache.org> wrote:
>
> +1 (binding)
>
> Tested with Docker Desktop integrated with k8s v1.27.
>
> - Deployed a cluster by using helm install pulsar
> apache-pulsar-dist-dev/pulsar --set affinity.anti_affinity=false
> - Tested produce and consume
>
> Regards,
> Penghui
>
> On Wed, Dec 20, 2023 at 12:25 AM Lari Hotari <lhot...@apache.org> wrote:
>
> > +1
> >
> > - Validated the release by installing to Docker Desktop integrated k8s
> > v1.28.
> >
> > Followed validation instructions at
> > https://github.com/apache/pulsar-helm-chart/blob/master/RELEASE.md#verify-the-release-candidate-by-the-pmc
> > :
> > - checked the packages are present in the right dist folder on svn
> > - verified that all the sources have correct licenses
> > - verified that release is signed with the right key
> > - verified that checksums are valid for the release
> >
> > I did have an issue with the .rat-excludes file since rat reports some
> > files without license headers and I wasn't able to exclude them after
> > spending some time in editing the file.
> > The files are under .github directory, mainly the issue templates. That
> > should be fine for the release.
> >
> > -Lari
> >
> > On 2023/12/11 12:24:19 Lari Hotari wrote:
> > > Hello Apache Pulsar Community,
> > >
> > > This is a call for the vote to release the Apache Pulsar Helm Chart
> > version 3.1.0.
> > >
> > > The release candidate is available at:
> > >
> > https://dist.apache.org/repos/dist/dev/pulsar/helm-chart/3.1.0-candidate-1/
> > >
> > > pulsar-chart-3.1.0-source.tar.gz - is the "main source release".
> > > pulsar-3.1.0.tgz - is the binary Helm Chart release.
> > >
> > > Public keys are available at: https://www.apache.org/dist/pulsar/KEYS
> > >
> > > For convenience "index.yaml" has been uploaded (though excluded from
> > voting), so you can also run the below commands.
> > >
> > > helm repo add apache-pulsar-dist-dev
> > https://dist.apache.org/repos/dist/dev/pulsar/helm-chart/3.1.0-candidate-1/
> > > helm repo update
> > > helm install pulsar apache-pulsar-dist-dev/pulsar
> > >
> > > pulsar-3.1.0.tgz.prov - is also uploaded for verifying Chart Integrity,
> > though it is not strictly required for releasing the artifact based on ASF
> > Guidelines.
> > >
> > > You can optionally verify this file using this helm plugin
> > https://github.com/technosophos/helm-gpg, or by using helm --verify (
> > https://helm.sh/docs/helm/helm_verify/).
> > >
> > > helm gpg verify pulsar-3.1.0.tgz
> > >
> > > The vote will be open for at least 72 hours.
> > >
> > > Only votes from PMC members are binding, but members of the community are
> > > encouraged to test the release and vote with "(non-binding)".
> > >
> > > For license checks, the .rat-excludes files is included, so you can run
> > the following to verify licenses (just update ):
> > >
> > > tar -xvf pulsar-chart-3.1.0-source.tar.gz
> > > cd pulsar-chart-3.1.0
> > > java -jar /apache-rat-0.15/apache-rat-0.15.jar . -E .rat-excludes
> > >
> > > Please note that the version number excludes the `-candidate-X` string,
> > so it's now
> > > simply 3.1.0. This will allow us to rename the artifact without modifying
> > > the artifact checksums when we actually release it.
> > >
> > > Thanks,
> > >
> > > Lari Hotari
> > >
> >

Reply via email to