Looks good to me.

Thank you,
Dragos

> On Dec 5, 2023, at 9:36 AM, Heesung Sohn <hees...@apache.org> wrote:
> 
> Hello Pulsar dev,
> 
> I propose that ExtensibleLoadBalancer expose the following two
> configurations in the ServiceConfiguration.
> 
> loadBalancerInFlightServiceUnitStateWaitingTimeInMillis=30000
> loadBalancerServiceUnitStateMonitorIntervalInSeconds=60
> 
> PR:
> https://github.com/apache/pulsar/pull/21668/files#diff-cc761e782083f37db72cd91684fee07b931c188dd93333397c62b0a4c45a657eR2664-R2684
> 
> Currently, these are hardcoded in the ServiceUnitStateChannel class, but I
> think they can be exposed to the ServiceConfiguration for users to
> fine-tune the behavior. I updated the PIP-192 to list the
> ExtensibleLoadBalancer's Service Configurations.
> 
> PIP-192: https://github.com/apache/pulsar/issues/16691
> 
> Regards,
> Heesung

Reply via email to