Hi, Mattison These images look good to me.
Regarding the image tag, it seems it couldn't find the git repo. I think it would work if you ran this command inside the Pulsar git repo instead of the plain folder. BR, Zike Yang On Sat, Aug 5, 2023 at 9:00 PM <mattisonc...@gmail.com> wrote: > > Hi, Zike > > The new candidate docker image has been uploaded. Could you please help > review it again? Thanks! > > pulsar: > > https://hub.docker.com/layers/mattison/pulsar/3.1.0-no-git/images/sha256-157aa5501a5d7fedb843e4e45d808c7276887d89b3bd5ffe22a41bbec9d1da3c?context=explore > > pulsar-all: > > https://hub.docker.com/layers/mattison/pulsar-all/3.1.0-no-git/images/sha256-92837021caca0b68c340c7959e642d52a5f41699293ece7831882afc109558cf?context=explore > > The docker image tag is a little bit weird though, but we can retag it when > moving it to apachepulsar repo. > > Best, > Mattison > On 4 Aug 2023 at 11:54 +0800, Zike Yang <z...@apache.org>, wrote: > > Hi, Mattison, > > > > > Note that this RC doesn't require a formal vote, but we would also > > appreciate your feedback with +1/-1. And please provide specific > > comments if your feedback is not +1. > > > > The `-1` is my feedback. It's not the vote. It's up to the release > > manager to decide whether to start a new RC immediately. > > Also, the -1 here doesn't block the verification. > > > > BR, > > Zike Yang > > > > On Fri, Aug 4, 2023 at 11:45 AM <mattisonc...@gmail.com> wrote: > > > > > > Hi, Dave > > > > > > I see. Thanks! > > > > > > Best, > > > Mattison > > > On 4 Aug 2023 at 11:18 +0800, Dave Fisher <wave4d...@comcast.net>, wrote: > > > > > Hi - > > > > > > > > > > Since this is a VERiFY then the -1 with a technical reason is good > > > > > data for the Release Manager. They can decide when there is enough > > > > > feedback before cutting a new release. > > > > > > > > > > Good work! > > > > > > > > > > Best, > > > > > Dave > > > > > > > > > > Sent from my iPhone > > > > > > > > > > > > On Aug 3, 2023, at 7:49 PM, mattisonc...@gmail.com wrote: > > > > > > > > > > > > > > Hi, Zike Yang > > > > > > > > > > > > > > We can rebuild this image to support multiple versions. But I > > > > > > > think we don't need to start another candidate. > > > > > > > > > > > > > > Also, I wonder if it's ok to give -1 here. We should only set > > > > > > > this item to required if the new release process has been updated. > > > > > > > > > > > > > > Plus, we should add this part to the build-shell script once it > > > > > > > is required.[1] > > > > > > > > > > > > > > WDYT? > > > > > > > > > > > > > > Best, > > > > > > > Mattison > > > > > > > > > > > > > > > > > > > > > [1] https://github.com/apache/pulsar/blob/master/docker/build.sh > > > > > > > > > > > On 3 Aug 2023 at 23:44 +0800, Zike Yang > > > > > > > > > > > <z...@apache.org>, wrote: > > > > > > > > > > > -1 > > > > > > > > > > > > > > > > > > > > > > The docker image doesn't support the `arm64` arch. > > > > > > > > > > > Please use this command to build the image: > > > > > > > > > > > ```shell > > > > > > > > > > > mvn install > > > > > > > > > > > -DUBUNTU_MIRROR=http://azure.archive.ubuntu.com/ubuntu/ \ > > > > > > > > > > > -DskipTests \ > > > > > > > > > > > -Pmain,docker -Pdocker-push \ > > > > > > > > > > > -Ddocker.platforms=linux/amd64,linux/arm64 \ > > > > > > > > > > > -Ddocker.organization=$DOCKER_USER \ > > > > > > > > > > > -pl docker/pulsar,docker/pulsar-all > > > > > > > > > > > ``` > > > > > > > > > > > > > > > > > > > > > > The release process of the docker image is still being > > > > > > > > > > > updated. But > > > > > > > > > > > you can check this PR for more information: > > > > > > > > > > > https://github.com/apache/pulsar-site/pull/595 > > > > > > > > > > > > > > > > > > > > > > BR, > > > > > > > > > > > Zike Yang > > > > > > > > > > > > > > > > > > > > > > > > >> On Thu, Aug 3, 2023 at 8:53 PM guo jiwei > > > > > > > > > > > > > >> <techno...@apache.org> wrote: > > > > > > > > > > > > > >> > > > > > > > > > > > > > >> This is the first release candidate for Apache > > > > > > > > > > > > > >> Pulsar version 3.1.0. > > > > > > > > > > > > > >> > > > > > > > > > > > > > >> It fixes the following issues: > > > > > > > > > > > > > >> https://github.com/apache/pulsar/milestone/35?closed=1 > > > > > > > > > > > > > >> > > > > > > > > > > > > > >> *** Please download, test and verify on this > > > > > > > > > > > > > >> release. This release > > > > > > > > > > > > > >> candidate verification will stay open until Aug 8 > > > > > > > > > > > > > >> *** > > > > > > > > > > > > > >> > > > > > > > > > > > > > >> Note that we are verifying upon the source (tag), > > > > > > > > > > > > > >> binaries are provided for > > > > > > > > > > > > > >> convenience. > > > > > > > > > > > > > >> > > > > > > > > > > > > > >> Source and binary files: > > > > > > > > > > > > > >> https://dist.apache.org/repos/dist/dev/pulsar/pulsar-3.1.0-candidate-1/ > > > > > > > > > > > > > >> > > > > > > > > > > > > > >> SHA-512 checksums: > > > > > > > > > > > > > >> > > > > > > > > > > > > > >> d3cc4850d31a48f218575e85419e5752e377d2900476bf63381747e307046e9beb5d44b7f45ffd1a14dc971b707824700a0192135e1a63cf0746a3061e261399 > > > > > > > > > > > > > >> > > > > > > > > > > > > > >> apache-pulsar-3.1.0-bin.tar.gz > > > > > > > > > > > > > >> > > > > > > > > > > > > > >> a97557e65116736ad98b19bbcd81926013eec2591b89237913a96960d08a81f656feb6c8ad1a5a74eaf9b59369b4ec8bf4b5b09a0bd0d6ed072fda986e115901 > > > > > > > > > > > > > >> > > > > > > > > > > > > > >> apache-pulsar-3.1.0-src.tar.gz > > > > > > > > > > > > > >> > > > > > > > > > > > > > >> Maven staging repo: > > > > > > > > > > > > > >> https://repository.apache.org/content/repositories/orgapachepulsar-1241/ > > > > > > > > > > > > > >> > > > > > > > > > > > > > >> The tag to verify: > > > > > > > > > > > > > >> v3.1.0-candidate-1 > > > > > > > > > > > > > >> (8d89904bcc9e0a726435fec44e3eb03663924231) > > > > > > > > > > > > > >> https://github.com/apache/pulsar/releases/tag/v3.1.0-candidate-1 > > > > > > > > > > > > > >> > > > > > > > > > > > > > >> Pulsar's KEYS file containing PGP keys you use to > > > > > > > > > > > > > >> sign the release: > > > > > > > > > > > > > >> https://dist.apache.org/repos/dist/dev/pulsar/KEYS > > > > > > > > > > > > > >> > > > > > > > > > > > > > >> Docker images: > > > > > > > > > > > > > >> > > > > > > > > > > > > > >> pulsar images: > > > > > > > > > > > > > >> https://hub.docker.com/layers/mattison/pulsar/3.1.0-candidate-1/images/sha256-0efbaad7d893cc5041a46a2d4d56432bda855ae4068a38349777d1be6e98d27d?context=explore > > > > > > > > > > > > > >> > > > > > > > > > > > > > >> pulsar-all images: > > > > > > > > > > > > > >> https://hub.docker.com/layers/mattison/pulsar-all/3.1.0-candidate-1/images/sha256-d12f9a1af99979b9a20babdefebc8645f737318d879b77eb06f171489269e1fc?context=explore > > > > > > > > > > > > > >> > > > > > > > > > > > > > >> Please download the source package, and follow the > > > > > > > > > > > > > >> README to build > > > > > > > > > > > > > >> and run the Pulsar standalone service. > > > > > > > > > > > > > >> > > > > > > > > > > > > > >> Note that this RC doesn't require a formal vote, > > > > > > > > > > > > > >> but we would also > > > > > > > > > > > > > >> appreciate your feedback with +1/-1. And please > > > > > > > > > > > > > >> provide specific > > > > > > > > > > > > > >> comments if your feedback is not +1. > > > > > > > > > > > > > >> > > > > > > > > > > > > > >> Regards > > > > > > > > > > > > > >> Jiwei Guo (Tboy) > > > > >
