+1 binding
Thanks,
Haiting
On Wed, Jun 28, 2023 at 10:17 AM houxiaoyu <houxia...@apache.org> wrote:
>
> +1 (non-binding)
>
> Xiaoyu Hou
>
> steven lu <lushiji2...@gmail.com> 于2023年6月28日周三 09:40写道：
>
> > Hi, community:
> >
> > # Motivation
> >
> > reformat property,for a http header name cannot contain the following
> > prohibited characters: =,;: \t\r\n\v\f
> >
> > for example:
> > {"city=shanghai":"tag"}
> > when we run `bin/pulsar-admin topics get-message-by-id `, it will
> > throw exception, the exception is:
> > `Reason: java.util.concurrent.CompletionException:
> >
> > org.apache.pulsar.client.admin.internal.http.AsyncHttpConnector$RetryException:
> > Could not complete the operation. Number of retries has been
> > exhausted. Failed reason: a header name cannot contain the following
> > prohibited characters: =,;: \t\r\n\v\f: =`
> >
> > # High Level Design
> >
> > In master branch,
> > in an http
> > request:getMessageById("/{tenant}/{namespace}/{topic}/ledger/{ledgerId}/entry/{entryId}"),
> > replace `"X-Pulsar-PROPERTY-" + msgProperties.getKey()` with
> > `"X-Pulsar-PROPERTY"`
> >
> > After release-3.1.0, this feature begins to take effect.
> >
> >
> > PIP: https://github.com/apache/pulsar/pull/20627
> >
> > PR: https://github.com/apache/pulsar/pull/20481
> >
