Thanks, @Michael. @Asaf > Perhaps add a new metric with correct name and mark that one deprecated. Looks good
Regards Jiwei Guo (Tboy) On Mon, Jun 5, 2023 at 4:23 AM Asaf Mesika <asaf.mes...@gmail.com> wrote: > You will break anyone using this from 2017. > Perhaps add a new metric with correct name and mark that one deprecated. > Next LTS version it can be removed? > > How does this things managed? > > On Sat, Jun 3, 2023 at 2:34 AM Dave Fisher <wave4d...@comcast.net> wrote: > > > There are two PIP-273s. Whichever was last please update. > > > > Sent from my iPhone > > > > > On Jun 2, 2023, at 2:41 PM, Michael Marshall <mmarsh...@apache.org> > > wrote: > > > > > > +1. Can we also add a test to verify that this kind of addition isn't > > > possible in the future? > > > > > > On a procedure note, I created PIP 273 earlier this week. I think this > > > is PIP 274. > > > > > > Thanks, > > > Michael > > > > > >> On Fri, Jun 2, 2023 at 2:40 AM Yubiao Feng > > >> <yubiao.f...@streamnative.io.invalid> wrote: > > >> > > >> Hi Jiwei > > >> > > >> +1 > > >> > > >> Thanks > > >> Yubiao Feng > > >> > > >>> On Fri, Jun 2, 2023 at 3:23 PM guo jiwei <techno...@apache.org> > wrote: > > >>> > > >>> Hi, community: > > >>> The metrics are all started with `pulsar_`, so that both users and > > >>> operators can quickly find the metrics of the entire system through > > >>> this prefix. However, due to some other reasons, it was found that > > >>> `topic_load_times` was missing the prefix, so want to get it right. > > >>> In master release, change : > > >>> * `topic_load_times`: -> `pulsar_topic_load_times` > > >>> > > >>> > > >>> > > >>> Regards > > >>> Jiwei Guo (Tboy) > > >>> > > > > >
