fixed : - ) and more git code link provide in the pip.
At 2023-05-29 09:31:31, "PengHui Li" <peng...@apache.org> wrote: >> managedLedgerInfoCompressionThresholdInBytes >managedLedgerInfoCompressionThresholdInBytes > >It should be > >managedLedgerInfoCompressionThresholdInBytes >managedCursorInfoCompressionThresholdInBytes > >And it is better to add a link to the data structure to help >reviewers to understand the proposal. > >Regards, >Penghui > >On Sun, May 28, 2023 at 5:53 AM lifepuzzlefun <wjl_is_...@163.com> wrote: > >> agree. update the pip with more backgroud. >> >> >> On 2023/05/22 12:19:12 Asaf Mesika wrote: >> > Hi, >> > >> > I have a couple of questions: >> > >> > current we support to set compression on ManagedLedger and ManagedCursor >> > > metadata >> > > by managedLedgerInfoCompressionType and >> managedCursorInfoCompressionType >> > >> > >> > Can you please elaborate what is the metadata of ManagedLedger and >> > ManagedCursor? >> > Where is that metadata saved to? >> > Can you elaborate the managed ledger role in short - it's the underlying >> > object for topics right? >> > >> > I would be grateful if you can expand the PIP, so the reader will have >> > answers to those questions when reading it. >> > >> > >> > On Thu, May 11, 2023 at 7:28 PM Enrico Olivelli <eo...@gmail.com> wrote: >> > >> > > Makes sense to me. >> > > Thanks for your contribution >> > > >> > > Enrico >> > > >> > > Il giorno gio 11 mag 2023 alle ore 18:01 lifepuzzlefun >> > > <wj...@163.com> ha scritto: >> > > > >> > > > Dear Pulsar community, >> > > > >> > > > >> > > > I create a pip aim to add configuration on size based metadata >> > > compresssion. >> > > > >> > > > >> > > > https://github.com/apache/pulsar/issues/20307 >> > > > >> > > > >> > > > We welcome your feedback and suggestions on this proposal. >> > > > >> > > >> >