It makes sense to me, I have cherry-picked it to branch-3.1 now. I think we need to open another candidate for it.
Thanks, Yunze On Mon, Jan 23, 2023 at 4:34 PM Masahiro Sakamoto <massa...@yahoo-corp.jp> wrote: > > Hi Matteo, > > I faced an issue that a segmentation fault occurred when running a Node.js > application with the following combinations: > > - Node.js v18 > - Pulsar Node.js client v1.7.0 (wraps C++ client) > - Pulsar C++ client v3.1.0 > > This issue seems to be caused by the symbols of the libraries included in the > C++ client being exposed. As a test, I tried importing the following PR into > the C++ client v3.1.0, and the segmentation fault was no longer reproduced. > https://github.com/apache/pulsar-client-cpp/pull/155 > > It would be great if you could include this fix in v3.1.1. > > Thanks, > > Masahiro Sakamoto > Yahoo Japan Corp. > E-mail: massa...@yahoo-corp.jp > > -----Original Message----- > From: Yunze Xu <y...@streamnative.io.INVALID> > Sent: Friday, January 20, 2023 5:53 PM > To: dev@pulsar.apache.org > Subject: Re: [VOTE] Pulsar Client C++ Release 3.1.1 Candidate 1 > > +1 (binding) > > * verify checksum and signatures > * build from source (Ubuntu 20.04 WSL) > * verify artifacts on Windows (`pulsar.dll` and `pulsarWithDeps.a` for > both x86 and x64 architectures) > * verify rpm, deb, apk packages in x86_64 architecture (`libpulsar.so` > and `libpulsarwithdeps.a`) > > All the verifications are done by following the guide in > https://github.com/BewareMyPower/pulsar-client-cpp-demo > > Thanks, > Yunze > > On Fri, Jan 20, 2023 at 10:01 AM Matteo Merli <mme...@apache.org> wrote: > > > > This is the first release candidate for Apache Pulsar Client C++, version > > 3.1.1. > > > > It fixes the following issues: > > https://github.com/apache/pulsar-client-cpp/issues?q=label%3Arelease%2F3.1.1 > > > > *** Please download, test and vote on this release. This vote will stay open > > for at least 72 hours *** > > > > Note that we are voting upon the source (tag), binaries are provided for > > convenience. > > > > Source and binary files: > > https://jpn01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdist.apache.org%2Frepos%2Fdist%2Fdev%2Fpulsar%2Fpulsar-client-cpp%2Fpulsar-client-cpp-3.1.1-candidate-1%2F&data=05%7C01%7Cmassakam%40yahoo-corp.jp%7Cd91906002736404a0d5508dafac3ce76%7Ca208d369cd4e4f87b11998eaf31df2c3%7C1%7C0%7C638098016283187325%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=BSsmsTkFLHv3nU2kJv664cSfzptbshnJyqczQBbtoUQ%3D&reserved=0 > > > > SHA-512 checksums: > > ff7a98e8702d1086150cc1cbd10827b78d2d23cd7ca639d5590fb37d122b68c7ed70c2e38a24c94375871d868f9f04263b8991668e8498664bc3c1fa644b0be0 > > apache-pulsar-client-cpp-3.1.1.tar.gz > > > > The tag to be voted upon: > > v3.1.1-candidate-1 (24887d9f43471d6b333179000f9c931d64832037) > > https://github.com/apache/pulsar-client-cpp/releases/tag/v3.1.1-candidate-1 > > > > Pulsar's KEYS file containing PGP keys you use to sign the release: > > https://jpn01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdist.apache.org%2Frepos%2Fdist%2Fdev%2Fpulsar%2FKEYS&data=05%7C01%7Cmassakam%40yahoo-corp.jp%7Cd91906002736404a0d5508dafac3ce76%7Ca208d369cd4e4f87b11998eaf31df2c3%7C1%7C0%7C638098016283343560%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=3aMUcYx6A77%2FJpsKF%2FLueAUMcviola78Rj1EerMuKFQ%3D&reserved=0 > > > > Please download the source package, and follow the README to compile and > > test. > > > > -- > > Matteo Merli > > <mme...@apache.org>
