> +1, LGTM but it should only be applied in 2.12.0 or later.

Yes, I agree with you.

Thanks,
Bo

Yunze Xu <y...@streamnative.io.invalid> 于2022年12月16日周五 19:02写道:
>
> +1, LGTM but it should only be applied in 2.12.0 or later.
>
> Thanks,
> Yunze
>
> On Fri, Dec 16, 2022 at 6:26 PM Enrico Olivelli <eolive...@gmail.com> wrote:
> >
> > I support this solution.
> >
> > Unfortunately it is better to not port this to the previous versions
> > because it is a behaviour change.
> >
> > Thanks for driving this effort
> >
> > Enrico
> >
> > Il giorno ven 16 dic 2022 alle ore 10:31 丛搏 <bog...@apache.org> ha scritto:
> > >
> > > Hi, pulsar community:
> > >
> > > I start a PIP about modifying MessageIdImpl and BatchMessageIdImpl
> > > compareTo(MessageId o) method
> > >
> > > original discussion thread:
> > > https://lists.apache.org/thread/8n3oyk2hdsskkotnj4lnlvfnndctpqbg
> > >
> > > PIP: https://github.com/apache/pulsar/issues/18957
> > >
> > > Thanks,
> > > Bo

Reply via email to