Sent from my iPhone
> On Dec 8, 2022, at 9:30 PM, Michael Marshall <mmarsh...@apache.org> wrote:
>
> I ran `java -jar ~/Downloads/apache-rat-0.15/apache-rat-0.15.jar .`
> and I see that all but these two files have license headers:
>
> pulsar-client-reactive-adapter/src/main/resources/META-INF/services/org.apache.pulsar.reactive.client.api.MessageGroupingFunction
> pulsar-client-reactive-producer-cache-caffeine/src/main/resources/META-INF/services/org.apache.pulsar.reactive.client.adapter.ProducerCacheProviderFactory
>
> Is that a problem?
Not a problem, I doubt those metadata files support comments.
>
> Otherwise:
>
> - Verified checksum is valid
> - Verified signature is valid
> - Unable to (easily) build from source distribution. This would be
> worth improving later and I do not think it needs to hold up the
> release.
>
> Thanks,
> Michael
>
>
>> On Thu, Dec 8, 2022 at 12:43 PM Dave Fisher <w...@apache.org> wrote:
>>
>> +1 (binding)
>>
>> Checksum and signatures are valid.
>> LICENSE and NOTICE are present and valid
>> No binaries in the release.
>> Sources have AL2 license headers.
>>
>> LGTM,
>> Dave
>>
>>>> On Dec 8, 2022, at 7:07 AM, Christophe Bornet <bornet.ch...@gmail.com>
>>>> wrote:
>>>
>>> +1 (non-binding)
>>>
>>> - Followed the release validation procedure:
>>> - verified checksum and signature
>>> - verified sources match git tag
>>> - Ran successfully Spring-Pulsar test suite with the staged artifacts from
>>> the Maven repo
>>>
>>> Best regards.
>>>
>>> Christophe
>>>
>>>> Le jeu. 8 déc. 2022 à 14:31, Lari Hotari <lhot...@apache.org> a écrit :
>>>
>>>> Following PIP-205: Reactive Java client for Apache Pulsar (
>>>> https://github.com/apache/pulsar/issues/17335), this is release
>>>> candidate 2 for the Reactive Java client for Apache Pulsar, version 0.1.0.
>>>>
>>>> *** Please download, test and vote on this release. This vote will stay
>>>> open
>>>> for at least 72 hours ***
>>>>
>>>> Note that we are voting upon the source (tag). Binaries in the Maven
>>>> repository
>>>> are provided for convenience.
>>>>
>>>> Source package:
>>>>
>>>> https://dist.apache.org/repos/dist/dev/pulsar/pulsar-client-reactive-0.1.0-candidate-2/
>>>>
>>>> SHA-512 checksums:
>>>> dee10f0caa37f0b9b273b286627dec3abf289f5b1f7f3f4ea67bfaeff0f2bf4af57983b61df2cedc06536ddc513f550a16e1ec27cd525b3e832fbffe1b08962f
>>>> pulsar-client-reactive-0.1.0-src.tar.gz
>>>>
>>>> Maven staging repo:
>>>> https://repository.apache.org/content/repositories/orgapachepulsar-1195/
>>>>
>>>> The tag to be voted upon:
>>>> v0.1.0-candidate-2 (d45c08827387bd8d2a0d6bdc542c2bf7e4ebcda8)
>>>>
>>>> https://github.com/apache/pulsar-client-reactive/releases/tag/v0.1.0-candidate-2
>>>>
>>>> Please download the source package, and follow detailed instructions for
>>>> pulsar-client-reactive release validation at
>>>> https://github.com/apache/pulsar-client-reactive/wiki/Release-process#release-validation
>>>> .
>>>>
>>>> Best regards
>>>>
>>>> Lari Hotari
>>>>
>>
