Anonymitaet commented on code in PR #71:
URL: https://github.com/apache/pulsar-test-infra/pull/71#discussion_r973950108


##########
docbot/action.go:
##########
@@ -13,10 +13,7 @@ import (
 )
 
 const (
-       MessageLabelMissing = `Please provide a correct documentation label for 
your PR.
-Instructions see [Pulsar Documentation Label 
Guide](https://docs.google.com/document/d/1Qw7LHQdXWBW9t2-r-A7QdFDBwmZh6ytB4guwMoXHqc0).`
-       MessageLabelMultiple = `Please select only one documentation label for 
your PR.
-Instructions see [Pulsar Documentation Label 
Guide](https://docs.google.com/document/d/1Qw7LHQdXWBW9t2-r-A7QdFDBwmZh6ytB4guwMoXHqc0).`
+       MessageLabelMultiple = "Please select only one documentation label in 
your PR description."

Review Comment:
   1. The contents of `Pulsar Documentation Label Guide` will be moved to the 
Pulsar website, so the external links is a temporary state, do not need to 
worry about that (accessibility). 
   
   2. "How to make contributions to Pulsar" is a pretty big topic, which 
contains a lot of content. This content should be put into different guides 
(eg. `label guide`, `PR title naming guide`, `writing style guide`, `design 
guide`) rather than a single guide (eg. `Pulsar Contribution Guide`) since
   
   1) they have different subjects
   2) Readers: do not have the patience to read a "long" book 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to