+1(binding) Great work !
Regards Jiwei Guo (Tboy) On Fri, Sep 9, 2022 at 10:10 AM PengHui Li <peng...@apache.org> wrote: > +1(binding) > > I have done the review on gdoc > And please also update the github issue(PIP). > > Thanks, > Penghui > > On Fri, Sep 9, 2022 at 9:31 AM 丛搏 <congbobo...@gmail.com> wrote: > > > Hi, Xiangying > > +1(non-binding) > > > > This PIP overall LGTM! It solves the problem of snapshots not being > > able to scale. > > We can make some optimizations later : > > 1. Merge transaction snapshot segments to reduce the number of > > segments and the index's size. > > 2. Add snapshot segments to memory as TB requires reducing memory > overhead. > > > > Thanks! > > Bo > > > > Xiangying Meng <xiangy...@apache.org> 于2022年9月8日周四 22:17写道： > > > > > > Hi, community > > > This proposal has some updates. The latest version of the proposal can > be > > > found here > > > < > > > https://docs.google.com/document/d/1hBk2nGcj0Os-ULi2q404gCoxIsPleGY8p5H1hqWD5kI/edit# > > > > > > . > > > Feel free to comment on this doc. > > > Sincerely, > > > Xiangying > > > > > > On Wed, Sep 7, 2022 at 4:55 PM Xiangying Meng <xiangy...@apache.org> > > wrote: > > > > > > > Hi, community > > > > I,d like to start a vote for the PIP-196 > > > > <https://github.com/apache/pulsar/issues/16913> Segmented > transaction > > > > buffer snapshot. > > > > And the discussion can be found here > > > > <https://lists.apache.org/thread/bqoy3oz8flvxy7xpmnw81cr4c9sz5vy0>. > > > > > > > > Sincerely, > > > > Xiangying > > > > > > > > > > >
