That is interesting feedback, Hang. I wasn't familiar with the button when it appeared (even though I had read this email thread), and I definitely hit the "update branch" button several times thinking I was resolving conflicts.
Perhaps this new button contributed to the CI congestion we saw recently? Thanks, Michael On Thu, Sep 8, 2022 at 10:56 PM Hang Chen <chenh...@apache.org> wrote: > > Hi Nicolo, > Thanks for your proposal. After Pulsar enabled the `update > branch` bottom, I found a lot of Prs are blocked by running unit tests > due to a lot of unit tests rerun by the `update branch` action. The > update branch action will cause the CI resource busy and waste a lot > of resources if contributors or committers click the `update branch` > bottom many times for each PR. I think we need to add some > restrictions for the `update branch` bottom. Do you have any ideas? > > Thanks, > Hang > > Qiang Huang <qiang.huang1...@gmail.com> 于2022年8月24日周三 19:50写道： > > > > +1. It can help a lot. > > > > Zixuan Liu <node...@gmail.com> 于2022年8月22日周一 10:38写道： > > > > > +1 > > > > > > Best, > > > Zixuan > > > > > > On 2022/07/12 16:06:43 Nicolò Boschi wrote: > > > > Hi all, > > > > > > > > I'd like to propose to enable the Github button "update branch" in the > > > pull > > > > requests. > > > > > > > > The main reason is that it helps when you want to rebase your pull to > > > > the > > > > current master. > > > > For instance today a fix for a failing job in the CI has been committed > > > and > > > > you were forced to close/reopen the pull or manual rebase your branch. > > > With > > > > this button is much easier and it will retrigger the CI as well. > > > > > > > > This is the guide to enable it: > > > > > > > https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/keeping-your-pull-request-in-sync-with-the-base-branch > > > > > > > > This is an example where I activated the button in my own Pulsar fork: > > > > https://github.com/nicoloboschi/pulsar/pull/4 > > > > > > > > Thanks, > > > > Nicolò Boschi > > > > > > > > > > > > -- > > BR, > > Qiang Huang
