BewareMyPower commented on code in PR #219:
URL: https://github.com/apache/pulsar-client-node/pull/219#discussion_r904726822
##########
src/Consumer.cc:
##########
@@ -63,7 +63,9 @@ void MessageListenerProxy(Napi::Env env, Napi::Function
jsCallback, MessageListe
Consumer *consumer = data->consumer;
delete data;
- jsCallback.Call({msg, consumer->Value()});
+ if (consumer) {
Review Comment:
I think the controversial point is whether should we skip the null consumer.
- Yes: might lose messages (not sure)
- No: fast fail
Adding logs doesn't solve anything. There is no logger in NodeJS client,
printing logs to console is meaningless and helpless as I said.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
