I'm closing the VOTE. With 4 binding and 1 non-binding votes in favor, PIP-145 is accepted.
I'm going to update the issue with what has been agreed on in the discussion thread. Thanks, Andras On Thu, Mar 10, 2022 at 11:46 PM Michael Marshall <mmarsh...@apache.org> wrote: > +1 - thanks for the discussion on the other thread. > > > (seeing a mention about those problems in the PIP text would be great) > > I agree with Enrico that it'd be nice to see the outcome of the > discussion reflected in the PIP text. > > Thanks, > Michael > > On Thu, Mar 10, 2022 at 8:51 AM Hang Chen <chenh...@apache.org> wrote: > > > > +1. > > > > I agree with Enrico. We'd better address the comments pointed out my > > Micheal, especially for protection against malicious RegExps. > > > > Thanks, > > Hang > > > > Enrico Olivelli <eolive...@gmail.com> 于2022年3月10日周四 16:36写道： > > > > > > I have re-read the discussion thread a couple of times. > > > This solution works for me. > > > > > > I am sure that we will address during the implementation some details > > > (pointed out my Micheal Marshall) like: > > > - max number of observers > > > - protection about malicious RegExps > > > > > > (seeing a mention about those problems in the PIP text would be great) > > > > > > +1 > > > > > > Enrico > > > > > > Il giorno gio 10 mar 2022 alle ore 09:18 Matteo Merli > > > <matteo.me...@gmail.com> ha scritto: > > > > > > > > +1 > > > > -- > > > > Matteo Merli > > > > <matteo.me...@gmail.com> > > > > > > > > On Tue, Mar 8, 2022 at 4:41 PM PengHui Li <peng...@apache.org> > wrote: > > > > > > > > > > +1 > > > > > > > > > > Penghui > > > > > > > > > > On Tue, Mar 8, 2022 at 6:11 PM Andras Beni > > > > > <andras.b...@streamnative.io.invalid> wrote: > > > > > > > > > > > Hi Pulsar Community, > > > > > > > > > > > > I would like to start a VOTE on "Improve performance of regex > > > > > > subscriptions" (PIP-145). > > > > > > > > > > > > The proposal can be read at > https://github.com/apache/pulsar/issues/14505 > > > > > > and the discussion thead is available at > > > > > > https://lists.apache.org/thread/51y8s6tfw1p1h5dcb9fgzkzd8tw2bqpz > . > > > > > > > > > > > > Voting will stay open for at least 48h. > > > > > > > > > > > > Thanks, > > > > > > Andras > > > > > > >
