Il Lun 7 Mar 2022, 07:46 Haiting Jiang <jianghait...@apache.org> ha scritto:
> +1 for this great idea. > Although I am not sure if there is an easy and accurate way to "find new > or modified unit tests". > > Thanks, > Haiting > > On 2022/03/07 03:11:47 包子 wrote: > > Hi, I want to discuss how to improve the stability of unit testing.I > found that most flaky unit tests can be reproduc locally and only need to > be executed a few more times. > > > > Can we add the following mandatory constraints to ensure the stability > of unit testing of code? > > 1. If new / modified unit tests are included in PR, they need to be run > continuously on CI for more than n times. > > 2. We can write scripts and parse git change records to find new or > modified unit tests. > I am not sure that this helps. You can still be very lucky and unfortunately many times the impact is on other tests, not the new tests. I believe that the best weapons we have are: - Good code reviews - if there is a error on CI, don't default to 'rerun-failure-checks' but look carefully into the errors (we could disable the ability to rerun failed tests to non committers and so giving more control on CI to the committer who is sponsoring a patch) Enrico > > > >
