Thanks for identifying the issue and the fix, Enrico. I am closing this vote and will start preparing RC 4.
- Michael On Wed, Mar 2, 2022 at 1:22 AM Enrico Olivelli <eolive...@gmail.com> wrote: > > Michael, > > Il giorno mar 1 mar 2022 alle ore 12:47 Enrico Olivelli > <eolive...@gmail.com> ha scritto: > > > > I have sent a PR with the cherry-pick of > > https://github.com/apache/pulsar/commit/c90c89b07ce544b92becedfaa7a0090b4b73edd2 > > > > https://github.com/apache/pulsar/pull/14510 > > > > I am testing the patch locally now > > > With the patch, the Jakarta JMS TCK passes. > I have double checked and it is a regression of Pulsar 2.8.2. > > I believe that it is better to cut a new release. > I am very sorry because it looks like a waste of time for the Release > Manager and for whom tested the RC. > but it is better so see Pulsar playing like a rock star and that we > can say that it is still compatible with JMS > > The change is small and it does not affect users that do not use > Transactions, so the risk is very small > > Enrico > > > > > > > > Enrico > > > > > > Il giorno mar 1 mar 2022 alle ore 12:23 Enrico Olivelli > > <eolive...@gmail.com> ha scritto: > > > > > > Micheal, > > > I tested the RC, so far so good: > > > - built on JDK11 > > > - built the docker images > > > - run tests of some applications > > > - checked signatures, RAT.... > > > > > > > > > But while running the Jakarta JMS 2.0 TCK I am seeing a regression > > > regarding transactions, a NullPointerException here, on the Server, > > > and after this error the broker is stuck > > > > > > 11:09:00.673 [ForkJoinPool.commonPool-worker-27] ERROR > > > org.apache.pulsar.broker.transaction.buffer.impl.TopicTransactionBuffer > > > - [persistent://public/default/MY_QUEUE]Transaction buffer new > > > snapshot reader fail! > > > java.util.concurrent.CompletionException: java.lang.NullPointerException > > > at > > > java.util.concurrent.CompletableFuture.encodeThrowable(CompletableFuture.java:314) > > > [?:?] > > > at > > > java.util.concurrent.CompletableFuture.completeThrowable(CompletableFuture.java:319) > > > [?:?] > > > at > > > java.util.concurrent.CompletableFuture$UniAccept.tryFire(CompletableFuture.java:718) > > > [?:?] > > > at > > > java.util.concurrent.CompletableFuture$Completion.exec(CompletableFuture.java:479) > > > [?:?] > > > at java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:290) [?:?] > > > at > > > java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1020) > > > [?:?] > > > at java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1656) [?:?] > > > at java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1594) > > > [?:?] > > > at > > > java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:183) > > > [?:?] > > > Caused by: java.lang.NullPointerException > > > at > > > org.apache.pulsar.broker.transaction.buffer.impl.TopicTransactionBuffer$TopicTransactionBufferRecover.lambda$run$2(TopicTransactionBuffer.java:476) > > > ~[org.apache.pulsar-pulsar-broker-2.8.3.jar:2.8.3] > > > at > > > java.util.concurrent.CompletableFuture$UniAccept.tryFire(CompletableFuture.java:714) > > > ~[?:?] > > > ... 6 more > > > > > > This is probably worth a -1 > > > > > > I am investigating, > > > I am sorry for my late but I couldn't check the RC until today > > > > > > Enrico > > > > > > > > > Il giorno mar 1 mar 2022 alle ore 10:26 Nicolò Boschi > > > <boschi1...@gmail.com> ha scritto: > > > > > > > > +1 (non binding) > > > > > > > > Checks: > > > > > > > > - Checksum and signatures > > > > > > > > - Apache Rat check passes > > > > > > > > - Compile from source w JDK11 > > > > > > > > - Build docker image from source > > > > > > > > - Run Pulsar standalone and produce-consume from CLI > > > > > > > > - Deployed a cluster to a k8s env and tested simple functions (k8s mode) > > > > and the elastic sink using avro schema > > > > > > > > Il giorno ven 25 feb 2022 alle ore 04:46 Jiuming Tao > > > > <jm...@streamnative.io.invalid> ha scritto: > > > > > > > > > +1 > > > > > > > > > > > > > > > > 2022年2月25日 上午11:44，Michael Marshall <mmarsh...@apache.org> 写道： > > > > > > > > > > > > This is the third release candidate for Apache Pulsar, version > > > > > > 2.8.3. > > > > > > > > > > > > It fixes the following issues: > > > > > > https://github.com/apache/pulsar/compare/v2.8.2...v2.8.3-candidate-3 > > > > > > > > > > > > *** Please download, test and vote on this release. This vote will > > > > > > stay > > > > > open > > > > > > for at least 72 hours *** > > > > > > > > > > > > Note that we are voting upon the source (tag), binaries are > > > > > > provided for > > > > > > convenience. > > > > > > > > > > > > Source and binary files: > > > > > > https://dist.apache.org/repos/dist/dev/pulsar/pulsar-2.8.3-candidate-3/ > > > > > > > > > > > > There are many checksums and signatures to validate, including > > > > > > apache-pulsar-2.8.3-bin.tar.gz, apache-pulsar-2.8.3-src.tar.gz, > > > > > > apache-pulsar-offloaders-2.8.3-bin.tar.gz, and all of the > > > > > > connectors. > > > > > > All are located here: > > > > > > https://dist.apache.org/repos/dist/dev/pulsar/pulsar-2.8.3-candidate-3/. > > > > > > > > > > > > Unofficial Docker images: > > > > > > michaelmarshall/pulsar:2.8.3-rc3 > > > > > > michaelmarshall/pulsar-all:2.8.3-rc3 > > > > > > michaelmarshall/pulsar-standalone:2.8.3-rc3 > > > > > > michaelmarshall/pulsar-grafana:2.8.3-rc3 > > > > > > > > > > > > Maven staging repo: > > > > > > https://repository.apache.org/content/repositories/orgapachepulsar-1143/ > > > > > > > > > > > > The tag to be voted upon: > > > > > > v2.8.3-candidate-3 (eba2671080341728f80435a82d2966726168e9da) > > > > > > https://github.com/apache/pulsar/releases/tag/v2.8.3-candidate-3 > > > > > > > > > > > > Pulsar's KEYS file containing PGP keys we use to sign the release: > > > > > > https://dist.apache.org/repos/dist/dev/pulsar/KEYS > > > > > > > > > > > > Please download the source package, and follow the README to build > > > > > > and run the Pulsar standalone service. > > > > > > > > > > > > > > > > > > -- > > > > Nicolò Boschi
