Closing the vote with one -1 from Penghui. > We just confirmed yesterday that this is a breaking change, > I was just suspicious before, so do not share the information > to avoid confusing reviewers. For now, we confirmed it
I wonder if we should be more willing to share suspicions on the mailing list when releases are actively being prepared. I would have appreciated the notice, and I could have possibly helped confirm the issue. On the other hand, I respect that it is hard to know when to share a theory and when to test it out a bit more. > And not all the PRs get cherry-picked to 2.8.3? I think these were not included because they were labeled after I cherry picked PRs on Friday. I will take a look and try to cherry pick all of those before tagging the next release candidate. Thanks, Michael On Tue, Feb 15, 2022 at 12:52 AM PengHui Li <peng...@apache.org> wrote: > > Sorry Michael > > There is a breaking change introduced in branch-2.8. > Sorry for that I forget to update the 2.8.3 release process, > Only update the context in 2.9.2 and 2.10.0. > > We just confirmed yesterday that this is a breaking change, > I was just suspicious before, so do not share the information > to avoid confusing reviewers. For now, we confirmed it > > The fixed PR is https://github.com/apache/pulsar/pull/14288 > > And not all the PRs get cherry-picked to 2.8.3? > Please check the list > https://github.com/apache/pulsar/pulls?q=is%3Apr+label%3Arelease%2F2.8.3+is%3Aclosed+-label%3Acherry-picked%2Fbranch-2.8+ > If they are not a requirement for 2.8.3, we can move it to the next version. > For https://github.com/apache/pulsar/pull/14246, I can confirm, without > this fix, we will also introduce breaking change in 2.8.3 > > I have to give my -1 here > > Regards, > Penghui > > > On Tue, Feb 15, 2022 at 12:56 PM Michael Marshall <mmarsh...@apache.org> > wrote: > > > This is the first release candidate for Apache Pulsar, version 2.8.3. > > > > It fixes the following issues: > > https://github.com/apache/pulsar/compare/v2.8.2...v2.8.3-candidate-1 > > > > *** Please download, test and vote on this release. This vote will stay > > open > > for at least 72 hours *** > > > > Note that we are voting upon the source (tag), binaries are provided for > > convenience. > > > > Source and binary files: > > https://dist.apache.org/repos/dist/dev/pulsar/pulsar-2.8.3-candidate-1/ > > > > SHA-512 checksums: > > > > > > b9d48a92404bacb0505406f57974c9e1ceecfede12cdc286656dbf1ee75c204c0af67540945a5d7b0fb1e295b6f06317444932359fd9af29d4ee8ceefa13f0ee > > apache-pulsar-2.8.3-bin.tar.gz > > > > d31ee747ba2a796230dd052994214028761813057967e92599dcf51e1b64726178b5ba6e3676cc5e947d60ee0411b0f02cb1ffcd91ba8a4138d220bbec7b6731 > > apache-pulsar-2.8.3-src.tar.gz > > > > Unofficial Docker images: > > michaelmarshall/pulsar:2.8.3-rc1 > > michaelmarshall/pulsar-all:2.8.3-rc1 > > michaelmarshall/pulsar-standalone:2.8.3-rc1 > > michaelmarshall/pulsar-grafana:2.8.3-rc1 > > > > Maven staging repo: > > https://repository.apache.org/content/repositories/orgapachepulsar-1139/ > > > > The tag to be voted upon: > > v2.8.3-candidate-1 (f3234374b50ae25d5afc9e882d1e3eb50a79fffd) > > https://github.com/apache/pulsar/releases/tag/v2.8.3-candidate-1 > > > > Pulsar's KEYS file containing PGP keys we use to sign the release: > > https://dist.apache.org/repos/dist/dev/pulsar/KEYS > > > > Please download the source package, and follow the README to build > > and run the Pulsar standalone service. > >
