eolivelli commented on a change in pull request #223:
URL: https://github.com/apache/pulsar-helm-chart/pull/223#discussion_r804843537
##########
File path: charts/pulsar/templates/zookeeper-statefulset.yaml
##########
@@ -151,7 +157,9 @@ spec:
command:
- timeout
- "{{ .Values.zookeeper.probe.readiness.timeoutSeconds }}"
- - bin/pulsar-zookeeper-ruok.sh
+ - bash
Review comment:
Here in this line
It is strange that we are not using the script we provide with Pulsar.
I understand the reason but it won't be clear to people reading this code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
