Yunze, Il giorno mar 25 gen 2022 alle ore 13:14 Yunze Xu <y...@streamnative.io.invalid> ha scritto: > > Hi all (especially committers), > > I opened a PR to enable checkstyle plugin for pulsar-client module just now. > See https://github.com/apache/pulsar/pull/13940 > <https://github.com/apache/pulsar/pull/13940>.
Great work. > > It’s really a huge PR but I hope it could be included in Pulsar 2.10 release +1 > because pulsar-client is one of the most huge modules of Pulsar. And the > code style has been out of control for a long time. > > For Pulsar committers, please be careful to merge PRs that modify code in > pulsar-client module after this PR is merged because it could make master > branch broken. I am not sure if there is a way to revalidate the PRs. IIUC when you close/reopen a PR it is not merged again with latest master before rerunning CI Enrico > > Thanks, > Yunze
