Sorry, late response, please take a look at the previous reply. If you have good ideas, we could start a discussion.
On 2022/01/05 18:31:38 Michael Marshall wrote: > +1 - thanks for starting this thread. > > >171 commits? > > Why? > > This is too much in my opinion for a point release. > > I agree that this is a lot of commits, and especially since we only > just released 2.9.1. Note though that this is not a new phenomenon: > 2.8.2 had 251 commits on top of 2.8.1. [0] > > > Every change we cherry pick has a good chance to break the stability > > This is one of the challenges to our current cherry-pick based git > workflow. It's hard to decide which commits to cherry-pick, and it > requires a high level of effort to later verify the correctness of > what was cherry-picked. This is one of the reasons I am interested in > exploring a merge based git workflow. > > Our project has grown a ton and will continue to grow. Our git process > should prioritize the stability of our existing release branches. > > > And that we will let branch-2.9 stabilise by not adding any other commits > > that are not strictly required: > > - security related issues > > - data loss/data corruption cases > > If we don't change our git workflow, we should at least add a > cherry-picking guide to the wiki. We have added many new committers in > the past year, but we don't provide them with much documented guidance > on how to exercise their new rights. > > Thanks, > Michael > > [0] https://github.com/apache/pulsar/compare/v2.8.1...v2.8.2 > > > On Wed, Jan 5, 2022 at 11:44 AM Enrico Olivelli <eolive...@gmail.com> wrote: > > > > BTW +1 > > > > I hope we will review carefully what we are including in the release > > > > And that we will let branch-2.9 stabilise by not adding any other commits > > that are not strictly required: > > - security related issues > > - data loss/data corruption cases > > > > > > Enrico > > > > > > Thank you Ran Gao for starting this thread. > > > > > > > > Enrico > > > > Il Mer 5 Gen 2022, 17:29 Enrico Olivelli <eolive...@gmail.com> ha scritto: > > > > > 171 commits? > > > > > > Why? > > > > > > This is too much in my opinion for a point release. > > > > > > I am pretty sure that we don't need all that changes. > > > > > > Every change we cherry pick has a good chance to break the stability > > > > > > Enrico > > > > > > Il Mer 5 Gen 2022, 16:30 mattison chao <mattisonc...@gmail.com> ha > > > scritto: > > > > > >> +1 > > >> > > >> regards, > > >> Mattisonchao > > >> > > >> On Wed, 5 Jan 2022 at 23:04, Lan Liang <liangyuanpen...@163.com> wrote: > > >> > > >> > +1,Thanks for your work. > > >> > > > >> > > > >> > > > >> > > > >> > > > >> > > > >> > Best Regards, > > >> > Lan Liang > > >> > On 1/5/2022 23:01，Hang Chen<chenh...@apache.org> wrote： > > >> > +1 > > >> > > > >> > Best, > > >> > Hang > > >> > > > >> > 陳智弘 <thomasec...@gmail.com> 于2022年1月5日周三 21:30写道： > > >> > > > >> > +1 > > >> > > > >> > Lari Hotari <l...@hotari.net> 於 2022年1月5日 週三 20:56 寫道： > > >> > > > >> > +1 > > >> > > > >> > On Wed, Jan 5, 2022 at 11:23 AM Ran Gao <r...@apache.org> wrote: > > >> > > > >> > Hello, Pulsar community: > > >> > > > >> > I'd like to propose that we release Apache Pulsar 2.9.2. > > >> > > > >> > Currently, compared to 2.9.1, branch-2.9 already merged 171 > > >> commits(refer > > >> > to [0]), they contain the log4j security patch and many important > > >> > fixes. > > >> > > > >> > I am happy to volunteer to be the release manager. > > >> > > > >> > I see 4 merged PRs are labeled release/2.9.2 but not cherry-pick to > > >> > branch-2.9, I'll cherry-pick them, and there are also 20 open PRs are > > >> > labeled release/2.9.2, I'll follow them to make sure important fix > > >> > could > > >> > be > > >> > merged in 2.9.2. > > >> > > > >> > > > >> > Best, > > >> > Ran Gao > > >> > > > >> > > > >> > [0] https://github.com/apache/pulsar/compare/v2.9.1...branch-2.9 > > >> > > > >> > > > >> > > > >> > > > >
