michaeljmarshall commented on a change in pull request #205:
URL: https://github.com/apache/pulsar-helm-chart/pull/205#discussion_r789893579
##########
File path: charts/pulsar/templates/broker-configmap.yaml
##########
@@ -43,6 +43,62 @@ data:
zooKeeperSessionTimeoutMillis: "30000"
statusFilePath: "{{ template "pulsar.home" . }}/status"
+ # Tiered storage settings
+ {{- if .Values.broker.storageOffload.driver }}
+ {{- if eq .Values.broker.storageOffload.driver "aws-s3" }}
+ managedLedgerOffloadDriver: "{{ .Values.broker.storageOffload.driver }}"
+ s3ManagedLedgerOffloadBucket: "{{ .Values.broker.storageOffload.bucket }}"
+ s3ManagedLedgerOffloadRegion: "{{ .Values.broker.storageOffload.region }}"
+ AWS_ACCESS_KEY_ID: "{{ .Values.broker.storageOffload.accessKey }}"
+ AWS_SECRET_ACCESS_KEY: "{{ .Values.broker.storageOffload.accessSecret }}"
+ {{- if
.Values.broker.storageOffload.managedLedgerOffloadAutoTriggerSizeThresholdBytes
}}
+ PULSAR_PREFIX_managedLedgerOffloadThresholdInBytes: "{{
.Values.broker.storageOffload.managedLedgerOffloadAutoTriggerSizeThresholdBytes
}}"
+ {{- end }}
+ {{- if .Values.broker.storageOffload.managedLedgerOffloadDeletionLagMs }}
+ PULSAR_PREFIX_managedLedgerOffloadDeletionLagInMillis: "{{
.Values.broker.storageOffload.managedLedgerOffloadDeletionLagMs }}"
+ {{- end }}
+ {{- if .Values.broker.storageOffload.maxBlockSizeInBytes }}
+ s3ManagedLedgerOffloadMaxBlockSizeInBytes: "{{
.Values.broker.storageOffload.maxBlockSizeInBytes }}"
+ {{- end }}
+ {{- if .Values.broker.storageOffload.readBufferSizeInBytes }}
+ s3ManagedLedgerOffloadReadBufferSizeInBytes: "{{
.Values.broker.storageOffload.readBufferSizeInBytes }}"
+ {{- end }}
+ {{- end }}
+ {{- if eq .Values.broker.storageOffload.driver "google-cloud-storage" }}
+ managedLedgerOffloadDriver: "{{ .Values.broker.storageOffload.driver }}"
+ gcsManagedLedgerOffloadBucket: "{{ .Values.broker.storageOffload.bucket }}"
+ gcsManagedLedgerOffloadRegion: "{{ .Values.broker.storageOffload.region }}"
+ gcsManagedLedgerOffloadServiceAccountKeyFile:
"/pulsar/gcp-service-account/{{
.Values.broker.storageOffload.gcsServiceAccountJsonFile }}"
+ {{- if
.Values.broker.storageOffload.managedLedgerOffloadAutoTriggerSizeThresholdBytes
}}
+ PULSAR_PREFIX_managedLedgerOffloadThresholdInBytes: "{{
.Values.broker.storageOffload.managedLedgerOffloadAutoTriggerSizeThresholdBytes
}}"
+ {{- end }}
+ {{- if .Values.broker.storageOffload.managedLedgerOffloadDeletionLagMs }}
+ PULSAR_PREFIX_managedLedgerOffloadDeletionLagInMillis: "{{
.Values.broker.storageOffload.managedLedgerOffloadDeletionLagMs }}"
+ {{- end }}
+ {{- if .Values.broker.storageOffload.maxBlockSizeInBytes }}
+ gcsManagedLedgerOffloadMaxBlockSizeInBytes: "{{
.Values.broker.storageOffload.maxBlockSizeInBytes }}"
+ {{- end }}
+ {{- if .Values.broker.storageOffload.readBufferSizeInBytes }}
+ gcsManagedLedgerOffloadReadBufferSizeInBytes: "{{
.Values.broker.storageOffload.readBufferSizeInBytes }}"
+ {{- end }}
+ {{- end }}
+ {{- if eq .Values.broker.storageOffload.driver "azureblob" }}
+ managedLedgerOffloadDriver: "{{ .Values.broker.storageOffload.driver }}"
+ managedLedgerOffloadBucket: "{{ .Values.broker.storageOffload.bucket }}"
+ AZURE_STORAGE_ACCOUNT: "{{ .Values.broker.storageOffload.storageAccount }}"
+ AZURE_STORAGE_ACCESS_KEY: "{{
.Values.broker.storageOffload.storageAccountKey }}"
Review comment:
+1 - all of these keys should be in secrets that are mounted into the
broker pod. Great catch, @tuteng!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
