+1 - assuming we ensure that the `ThresholdShedder` has unit test coverage.
Thanks, Michael On Tue, Jan 11, 2022 at 9:53 PM r...@apache.org <ranxiaolong...@gmail.com> wrote: > > +1 (non-binding) > > -- > > Thanks > Xiaolong Ran > > Haiting Jiang <jianghait...@apache.org> 于2022年1月12日周三 09:52写道： > > > +1 > > > > On 2022/01/10 06:47:44 Hang Chen wrote: > > > This is the voting thread for PIP-122. It will stay open for at least 48 > > > hours. > > > > > > https://github.com/apache/pulsar/issues/13340 > > > > > > Pasted below for quoting convenience. > > > > > > ---- > > > > > > ### Motivation > > > The ThresholdShedder load balance policy since Pulsar 2.6.0 by > > > https://github.com/apache/pulsar/pull/6772. It can resolve many load > > > balance issues of `OverloadShedder` and works well in many Pulsar > > > production clusters. > > > > > > In Pulsar 2.6.0, 2.7.0, 2.8.0 and 2.9.0, Pulsar's default load balance > > > policy is `OverloadShedder`. > > > > > > I think it's a good time for 2.10 to change default load balance > > > policy to `ThresholdShedder`, it will make throughput more balance > > > between brokers. > > > > > > ### Proposed Changes > > > In 2.10 release，for `broker.conf`, change > > > `loadBalancerLoadSheddingStrategy` from > > > `org.apache.pulsar.broker.loadbalance.impl.OverloadShedder` to > > > `org.apache.pulsar.broker.loadbalance.impl.ThresholdShedder` > > > > >
