csthomas1 opened a new pull request #198: URL: https://github.com/apache/pulsar-helm-chart/pull/198
Fixes #197 ### Motivation Adds the -Dlog4j2.formatMsgNoLookups=true switch to the pulsar manager commandline. Necessary for pulsar manager v0.1.0, which includes a dependency on log4j2 2.10.0 ### Modifications Updated the pulsar manager deployment template to update the PULSAR_MANAGER_OPTS environment variable (supported by the pulsar manager startup script) to include -Dlog4j2.formatMsgNoLookups=true. ### Verifying this change **case 1**: -Dlog4j2.formatMsgNoLookups=true is included when PULSAR_MANAGER_OPTS has not been set in values.yaml: Install Pulsar via helm chart, making sure that the pulsar manager component is enabled: ``` helm install -n pulsar --set initialize=true pulsar pulsar-2.7.9.tgz ``` Exec into the pulsar manager pod and check that the Java process arguments include "-Dlog4j2.formatMsgNoLookups=true" **case 2**: -Dlog4j2.formatMsgNoLookups=true is appended to PULSAR_MANAGER_OPTS when PULSAR_MANAGER_OPTS is set in values.yaml: Install Pulsar via helm chart, setting a value for PULSAR_MANAGER_OPTS: ``` helm install -n pulsar --set initialize=true --set "pulsar_manager.configData.PULSAR_MANAGER_OPTS=-DmyTestOption=whatever" pulsar pulsar-2.7.9.tgz ``` Exec into the pulsar manager pod and check that the Java process arguments include "-DmyTestOption=whatever" and "-Dlog4j2.formatMsgNoLookups=true" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
