lhotari commented on a change in pull request #138:
URL: https://github.com/apache/pulsar-helm-chart/pull/138#discussion_r778603221
##########
File path: charts/pulsar/templates/bookkeeper-cluster-initialize.yaml
##########
@@ -16,7 +16,7 @@
# specific language governing permissions and limitations
# under the License.
#
-{{- if .Values.initialize }}
+{{- if .Release.IsInstall }}
Review comment:
I'd suggest keeping backwards compatibility.
```suggestion
{{- if or .Release.IsInstall .Values.initialize }}
```
The benefit of this is that the metadata initialization job can be created
on demand when needed. I have been using this in test environments. It's
possible to clear the persistent state of the cluster by scaling stateful sets
to 0, deleting PVCs and doing a deployment with `--set initialize=true`.
##########
File path: charts/pulsar/templates/pulsar-cluster-initialize.yaml
##########
@@ -17,7 +17,7 @@
# under the License.
#
-{{- if .Values.initialize }}
+{{- if .Release.IsInstall }}
Review comment:
```suggestion
{{- if or .Release.IsInstall .Values.initialize }}
```
##########
File path: charts/pulsar/values.yaml
##########
@@ -34,9 +34,6 @@ clusterDomain: cluster.local
### Global Settings
###
-## Set to true on install
Review comment:
please revert this change to keep backwards compatibility.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
