Il giorno lun 20 dic 2021 alle ore 13:21 PengHui Li <peng...@apache.org> ha scritto:
> Hi Enrico, > > Have you checked the CI status after completing the 2.9.1 PRs > cherry-picking? > When I created the tag I am pretty sure that CI on GH actions passed. I hope that no-one committed something to branch-2.9 If this happens, then we must enforce some rules about the fact that only the RM can commit to a branch under release. In ZooKeeper we create a "release branch" in order to prevent such problems Enrico > > Looks this test failed when I run the test with tag 2.9.1. > > ``` > [INFO] Running org.apache.pulsar.broker.transaction.TransactionTest > [ERROR] Tests run: 14, Failures: 1, Errors: 0, Skipped: 12, Time elapsed: > 26.782 s <<< FAILURE! - in > org.apache.pulsar.broker.transaction.TransactionTest > [ERROR] > > testCreateTransactionSystemTopic(org.apache.pulsar.broker.transaction.TransactionTest) > Time elapsed: 0.107 s <<< FAILURE! > java.lang.AssertionError: expected [4] but found [3] > at org.testng.Assert.fail(Assert.java:99) > at org.testng.Assert.failNotEquals(Assert.java:1037) > at org.testng.Assert.assertEqualsImpl(Assert.java:140) > at org.testng.Assert.assertEquals(Assert.java:122) > at org.testng.Assert.assertEquals(Assert.java:907) > at org.testng.Assert.assertEquals(Assert.java:917) > at > > org.apache.pulsar.broker.transaction.TransactionTest.testCreateTransactionSystemTopic(TransactionTest.java:145) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at > > org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:132) > at > > org.testng.internal.InvokeMethodRunnable.runOne(InvokeMethodRunnable.java:45) > at > org.testng.internal.InvokeMethodRunnable.call(InvokeMethodRunnable.java:73) > at > org.testng.internal.InvokeMethodRunnable.call(InvokeMethodRunnable.java:11) > at java.util.concurrent.FutureTask.run(FutureTask.java:266) > at > > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) > at > > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) > at java.lang.Thread.run(Thread.java:748) > > [INFO] > [INFO] Results: > [INFO] > [ERROR] Failures: > [ERROR] > > org.apache.pulsar.broker.transaction.TransactionTest.testCreateTransactionSystemTopic(org.apache.pulsar.broker.transaction.TransactionTest) > [INFO] Run 1: PASS > [ERROR] Run 2: TransactionTest.testCreateTransactionSystemTopic:145 > expected [4] but found [3] > [INFO] > [INFO] > [ERROR] Tests run: 9, Failures: 1, Errors: 0, Skipped: 7 > ``` > > Regards, > Penghui > > On Mon, Dec 20, 2021 at 3:06 PM Enrico Olivelli <eolive...@gmail.com> > wrote: > > > Hello everyone, > > The VOTE passed with 5 VOTEs, 3 of them were binding. > > > > - Matteo Merli (binding) > > - Enrico Olivelli (binding) > > - Peng Hui (binding) > > - Nicolò Boschi > > - Massimiliano Mirelli > > > > I will move forward with the next steps > > https://github.com/apache/pulsar/wiki/Release-process > > > > Enrico > > > > > > Il giorno sab 18 dic 2021 alle ore 11:41 PengHui Li <peng...@apache.org> > > ha > > scritto: > > > > > +1 binding > > > > > > Penghui > > > > > > Enrico Olivelli <eolive...@gmail.com>于2021年12月18日 周六18:39写道： > > > > > > > +1 (binding) > > > > > > > > - Run release validation procedure > > > > - CI is passing on those sources > > > > > > > > Enrico > > > > > > > > Il giorno sab 18 dic 2021 alle ore 02:51 PengHui Li < > > peng...@apache.org> > > > > ha > > > > scritto: > > > > > > > > > > Will this issue be fixed in the future releases? > > > > > > > > > > Yes, 2.8.2 and 2.9.2 will fix the problem. > > > > > > > > > > Penghui > > > > > > > > > > On Sat, Dec 18, 2021 at 3:28 AM Massimiliano Mirelli < > > > > > massimilianomirelli...@gmail.com> wrote: > > > > > > > > > > > Thank you for the rc! > > > > > > > > > > > > +1 (non-binding) > > > > > > > > > > > > * verify sha512 checksums > > > > > > * verify gpg signatures > > > > > > * build pulsar-all docker image > > > > > > * execute Fallout distributed system test (produce / receive 10k > > > > > messages) > > > > > > > > > > > > Building the docker image as indicated in the README: > > > > > > > > > > > > mvn clean install -DskipTests > > > > > > mvn package -Pdocker,-main -am -pl docker/pulsar-all -DskipTests > > > > > > > > > > > > I still get the error described in this PR#11951 ( > > > > > > https://github.com/apache/pulsar/pull/11951) which I suppose has > > > been > > > > > > cherry picked in 2.9.1. > > > > > > > > > > > > Giving enough permissions to /docker/pulsar/scripts/ in the src > > > package > > > > > and > > > > > > then building the docker image again solved the issue. > > > > > > > > > > > > I also tested the problem with the image Enrico provided, this > way: > > > > > > > > > > > > docker run -it --entrypoint bash eolivelli/pulsar-all:2.9.1rc2 > > > > > > ls -al /pulsar/bin > > > > > > > > > > > > and that one does have the right permissions. > > > > > > > > > > > > Enrico, did you build the image using the same mvn commands > (^^^), > > or > > > > is > > > > > > there some other way to build it? > > > > > > > > > > > > Thank you, > > > > > > Max > > > > > > > > > > > > On Fri, 17 Dec 2021 at 16:18, 陳智弘 <thomasec...@gmail.com> wrote: > > > > > > > > > > > > > Hi PengHu, > > > > > > > > > > > > > > Will this issue be fixed in the future releases? > > > > > > > > > > > > > > PengHui Li <peng...@apache.org> 於 2021年12月17日 週五 21:53 寫道： > > > > > > > > > > > > > > > Hi Enrico, > > > > > > > > > > > > > > > > I'm ok, it only happens when the message is without a schema > > > > version. > > > > > > > > So I'm not giving -1. > > > > > > > > > > > > > > > > Thanks, > > > > > > > > Penghui > > > > > > > > > > > > > > > > > > > > > > > > On Fri, Dec 17, 2021 at 7:33 PM Enrico Olivelli < > > > > eolive...@gmail.com > > > > > > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > Peng Hui, > > > > > > > > > > > > > > > > > > Il giorno ven 17 dic 2021 alle ore 08:09 PengHui Li < > > > > > > > peng...@apache.org> > > > > > > > > > ha > > > > > > > > > scritto: > > > > > > > > > > > > > > > > > > > Checked: > > > > > > > > > > > > > > > > > > > > - Build from the src > > > > > > > > > > - Check signatures > > > > > > > > > > - Follow the validation process > > > > > > > > > > > > > > > > > > > > But when I try to verify PulsarSQL, got following > > exceptions: > > > > > > > > > > > > > > > > > > > > ``` > > > > > > > > > > 2021-12-17T14:58:18.958+0800 ERROR remote-task-callback-3 > > > > > > > > > > io.prestosql.execution.StageStateMachine Stage > > > > > > > > > > 20211217_065818_00001_cahiv.1 failed > > > > > > > > > > > > > com.google.common.util.concurrent.UncheckedExecutionException: > > > > > > > > > > java.nio.BufferUnderflowException > > > > > > > > > > at > > > > > > > > > > > > com.google.common.cache.LocalCache$Segment.get(LocalCache.java:2051) > > > > > > > > > > at > > > > com.google.common.cache.LocalCache.get(LocalCache.java:3951) > > > > > > > > > > at > > > > > > > > > com.google.common.cache.LocalCache.getOrLoad(LocalCache.java:3974) > > > > > > > > > > at > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > com.google.common.cache.LocalCache$LocalLoadingCache.get(LocalCache.java:4935) > > > > > > > > > > at > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > org.apache.pulsar.sql.presto.PulsarSqlSchemaInfoProvider.getSchemaByVersion(PulsarSqlSchemaInfoProvider.java:76) > > > > > > > > > > at > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > org.apache.pulsar.sql.presto.PulsarRecordCursor.advanceNextPosition(PulsarRecordCursor.java:485) > > > > > > > > > > at > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > io.prestosql.spi.connector.RecordPageSource.getNextPage(RecordPageSource.java:90) > > > > > > > > > > at > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > io.prestosql.operator.TableScanOperator.getOutput(TableScanOperator.java:302) > > > > > > > > > > at > > > > io.prestosql.operator.Driver.processInternal(Driver.java:379) > > > > > > > > > > at > > > > > > io.prestosql.operator.Driver.lambda$processFor$8(Driver.java:283) > > > > > > > > > > at > > io.prestosql.operator.Driver.tryWithLock(Driver.java:675) > > > > > > > > > > at > > io.prestosql.operator.Driver.processFor(Driver.java:276) > > > > > > > > > > at > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > io.prestosql.execution.SqlTaskExecution$DriverSplitRunner.processFor(SqlTaskExecution.java:1075) > > > > > > > > > > at > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > io.prestosql.execution.executor.PrioritizedSplitRunner.process(PrioritizedSplitRunner.java:163) > > > > > > > > > > at > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > io.prestosql.execution.executor.TaskExecutor$TaskRunner.run(TaskExecutor.java:484) > > > > > > > > > > at > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > io.prestosql.$gen.Presto_332__testversion____20211217_065757_2.run(Unknown > > > > > > > > > > Source) > > > > > > > > > > at > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) > > > > > > > > > > at > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) > > > > > > > > > > at java.lang.Thread.run(Thread.java:748) > > > > > > > > > > Caused by: java.nio.BufferUnderflowException > > > > > > > > > > at java.nio.Buffer.nextGetIndex(Buffer.java:532) > > > > > > > > > > at > > java.nio.HeapByteBuffer.getLong(HeapByteBuffer.java:417) > > > > > > > > > > at > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > org.apache.pulsar.sql.presto.PulsarSqlSchemaInfoProvider.loadSchema(PulsarSqlSchemaInfoProvider.java:106) > > > > > > > > > > at > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > org.apache.pulsar.sql.presto.PulsarSqlSchemaInfoProvider.access$000(PulsarSqlSchemaInfoProvider.java:49) > > > > > > > > > > at > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > org.apache.pulsar.sql.presto.PulsarSqlSchemaInfoProvider$1.load(PulsarSqlSchemaInfoProvider.java:61) > > > > > > > > > > at > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > org.apache.pulsar.sql.presto.PulsarSqlSchemaInfoProvider$1.load(PulsarSqlSchemaInfoProvider.java:58) > > > > > > > > > > at > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > com.google.common.cache.LocalCache$LoadingValueReference.loadFuture(LocalCache.java:3529) > > > > > > > > > > at > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > com.google.common.cache.LocalCache$Segment.loadSync(LocalCache.java:2278) > > > > > > > > > > at > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > com.google.common.cache.LocalCache$Segment.lockedGetOrLoad(LocalCache.java:2155) > > > > > > > > > > at > > > > > > > > > > > > com.google.common.cache.LocalCache$Segment.get(LocalCache.java:2045) > > > > > > > > > > ... 18 more > > > > > > > > > > ``` > > > > > > > > > > > > > > > > > > > > An issue can be found here > > > > > > > > https://github.com/apache/pulsar/issues/12284 > > > > > > > > > , > > > > > > > > > > > > > > > > > > > > > > > > > > > > This doesn't look like a regression introduced in 2.9.1 > > > > > > > > > As this is a security related release I would continue the > > > > release > > > > > > > > process. > > > > > > > > > > > > > > > > > > What do you think ? > > > > > > > > > > > > > > > > > > Enrico > > > > > > > > > > > > > > > > > > > > > > > > > > > > my test steps are very simple: > > > > > > > > > > > > > > > > > > > > 1. Start presto worker, `bin/pulsar sql-worker run` > > > > > > > > > > 2. Produce some messages, `bin/pulsar-client produce -m > > > "hello" > > > > > -n > > > > > > 10 > > > > > > > > > > test_wordcount_src` > > > > > > > > > > 3. Query the data from the topic, `select * from > > > > > > > > > > pulsar."public/default"."test_wordcount_src";` > > > > > > > > > > > > > > > > > > > > Not able to query the produced data and get errors in the > > > > Pulsar > > > > > > SQL > > > > > > > > > > worker. > > > > > > > > > > > > > > > > > > > > Penghui > > > > > > > > > > > > > > > > > > > > On Fri, Dec 17, 2021 at 5:33 AM Matteo Merli < > > > > mme...@apache.org> > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > > +1 > > > > > > > > > > > > > > > > > > > > > > Checked: > > > > > > > > > > > * Signatures > > > > > > > > > > > * Bin distribution: > > > > > > > > > > > - NOTICE, README, LICENSE > > > > > > > > > > > - Start standalone service and producer/consumer > > test > > > > > > > > > > > * Src distribution: > > > > > > > > > > > - NOTICE, README, LICENSE > > > > > > > > > > > - Compile and unit tests > > > > > > > > > > > - Start standalone service > > > > > > > > > > > * Checked staging maven repository artifacts > > > > > > > > > > > * Checked docker images > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Matteo > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > > > > > Matteo Merli > > > > > > > > > > > <mme...@apache.org> > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > On Thu, Dec 16, 2021 at 12:53 PM Enrico Olivelli < > > > > > > > > eolive...@gmail.com> > > > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > > > > > I have pushed the docker images to my personal > dockehub > > > > > account > > > > > > > > > > > > > > > > > > > > > > > > eolivelli/pulsar:2.9.1rc2 > > > > > > > > > > > > eolivelli/pulsar-all:2.9.1rc2 > > > > > > > > > > > > > > > > > > > > > > > > Enrico > > > > > > > > > > > > > > > > > > > > > > > > Il Gio 16 Dic 2021, 15:57 Nicolò Boschi < > > > > > boschi1...@gmail.com> > > > > > > > ha > > > > > > > > > > > scritto: > > > > > > > > > > > > > > > > > > > > > > > > > +1 (non binding) > > > > > > > > > > > > > > > > > > > > > > > > > > Checks: > > > > > > > > > > > > > - Checksum and signatures > > > > > > > > > > > > > - Apache Rat check passes > > > > > > > > > > > > > - OWASP check passes (I created this PR for fix a > > false > > > > > > > positive > > > > > > > > > > > > > https://github.com/apache/pulsar/pull/13364) > > > > > > > > > > > > > - Compile from source w JDK11 > > > > > > > > > > > > > - Build docker image from source > > > > > > > > > > > > > - Run Pulsar standalone and produce-consume from > CLI > > > > > > > > > > > > > - verified the presence of Log4j 2.16.0 jar in > docker > > > and > > > > > > > tarball > > > > > > > > > > > > > > > > > > > > > > > > > > Il giorno gio 16 dic 2021 alle ore 14:25 Enrico > > > Olivelli > > > > < > > > > > > > > > > > > > eolive...@gmail.com> ha scritto: > > > > > > > > > > > > > > > > > > > > > > > > > > > This is the second release candidate for Apache > > > Pulsar, > > > > > > > version > > > > > > > > > > > 2.9.1. > > > > > > > > > > > > > > > > > > > > > > > > > > > > The first release candidate was aborted without > > > > starting > > > > > a > > > > > > > VOTE > > > > > > > > > > > because > > > > > > > > > > > > > we > > > > > > > > > > > > > > had to pick up high priority dependency upgrades. > > > > > > > > > > > > > > > > > > > > > > > > > > > > It fixes the following issues: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://github.com/apache/pulsar/pulls?q=is%3Apr++label%3Arelease%2F2.9.1+ > > > > > > > > > > > > > > > > > > > > > > > > > > > > *** Please download, test and vote on this > release. > > > > This > > > > > > vote > > > > > > > > > will > > > > > > > > > > > stay > > > > > > > > > > > > > > open > > > > > > > > > > > > > > for at least 72 hours *** > > > > > > > > > > > > > > > > > > > > > > > > > > > > Note that we are voting upon the source (tag), > > > binaries > > > > > are > > > > > > > > > > provided > > > > > > > > > > > for > > > > > > > > > > > > > > convenience. > > > > > > > > > > > > > > > > > > > > > > > > > > > > Source and binary files: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://dist.apache.org/repos/dist/dev/pulsar/pulsar-2.9.1-candidate-2/ > > > > > > > > > > > > > > > > > > > > > > > > > > > > SHA-512 checksums: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > 5ca7d2c6a8ac51413214796481095bbde50b5bda95d8b8f2467989931b29c75e679aabcfebd82e9e3e90dd1644c580214e0a05eca8652a500f042c84cb21becd > > > > > > > > > > > > > > apache-pulsar-2.9.1-bin.tar.gz > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > 34a1e22fb0ff2e69e7e880a9432526990610113cf89d93c953dff82cc443510dcf724eaa0e1fade82464f9bf5443655bd23bcf2064e312c4a9da70bb4c9937ba > > > > > > > > > > > > > > apache-pulsar-2.9.1-src.tar.gz > > > > > > > > > > > > > > > > > > > > > > > > > > > > Maven staging repo: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://repository.apache.org/content/repositories/orgapachepulsar-1110 > > > > > > > > > > > > > > > > > > > > > > > > > > > > The tag to be voted upon: > > > > > > > > > > > > > > v2.9.1-candidate-2 > > > > > > (f52ac045f41acbb6c31da21a3463df3cfbe8f1b4) > > > > > > > > > > > > > > > > > > > > > > > > https://github.com/apache/pulsar/releases/tag/v2.9.1-candidate-2 > > > > > > > > > > > > > > > > > > > > > > > > > > > > Link to the release notes: > > > > > > > > > > > > > > https://github.com/apache/pulsar/pull/13357 > > > > > > > > > > > > > > > > > > > > > > > > > > > > Pulsar's KEYS file containing PGP keys we use to > > sign > > > > the > > > > > > > > > release: > > > > > > > > > > > > > > > https://dist.apache.org/repos/dist/dev/pulsar/KEYS > > > > > > > > > > > > > > > > > > > > > > > > > > > > Please download the source package, and follow > the > > > > README > > > > > > to > > > > > > > > > build > > > > > > > > > > > > > > and run the Pulsar standalone service. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Enrico Olivelli > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > > > > > > > Nicolò Boschi > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > >
