ping
Il giorno ven 5 nov 2021 alle ore 09:23 Enrico Olivelli <eolive...@gmail.com> ha scritto: > Hello, > This patch [1] contains a .jar file that must not be committed to the > source repository. > We generally cannot commit binary files to the source repo, as it won't be > "open source" anymore. > > When we are permitted to commit binary/compiled code, there must be a very > good reason and it must be approved explicitly and noted somewhere (NOTICE > file?) > > My point here is that we are missing some automated check to prevent such > accidental commits. > I believe that we have to add a check to be run at every PR validation and > during the release process that our source distribution does not contain > compiled code. > > Thoughts ? > > Enrico > > [1] https://github.com/apache/pulsar/pull/12535 > >
