frankjkelly commented on a change in pull request #159:
URL: https://github.com/apache/pulsar-helm-chart/pull/159#discussion_r703497200
##########
File path: charts/pulsar/templates/bookkeeper-service.yaml
##########
@@ -33,7 +33,7 @@ metadata:
spec:
ports:
- name: bookie
- port: {{ .Values.bookkeeper.ports.bookie }}
Review comment:
@lhotari thanks for the feedback. @addisonj or @sijie Lari raises a
great point - is there another way around this?
Istio also supports setting the `appProtocol` but requires Kubernetes 1.18+
https://istio.io/latest/docs/ops/configuration/traffic-management/protocol-selection/#explicit-protocol-selection
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
