PetterIsberg commented on a change in pull request #85:
URL: https://github.com/apache/pulsar-dotpulsar/pull/85#discussion_r685868329
##########
File path: src/DotPulsar/Internal/Watchdog.cs
##########
@@ -0,0 +1,61 @@
+namespace DotPulsar.Internal
+{
+ using System;
+ using System.Collections.Generic;
+ using System.Text;
+ using System.Threading;
+
+ public class Watchdog: IDisposable
+ {
+ private CancellationTokenSource _cancellationTokenSource;
+ private readonly TimeSpan _timeout;
+ private readonly Timer _timer;
+
+ public Watchdog(TimeSpan timeout)
+ {
+ _timeout = timeout;
Review comment:
I think it would be up to the client to set a timeout that takes server
configuration, network travel time and packet loss into consideration. E.g.
server ping time x2 or x3.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
