-0 (non binding) - verified the signatures and checksums - apache RAT passes - run tests, on jdk8 on MacOs and Ubuntu, there are tests failures - run distributed system tests with Fallout, all is okay - run smoke tests with Pulsar Standalone, all is okay
I am voting "0" because I don't feel comfortable with releasing something with the tests that are consistently failing. thank you CongBo for driving the release Best regards Enrico Olivelli Il giorno gio 29 lug 2021 alle ore 18:21 Enrico Olivelli < eolive...@gmail.com> ha scritto: > I am performing again my tests, sorry for so late reply. > > If you see that some tests are consistently failing and we already have a > fix, in my humble opinion it is better to apply the fix and roll a new > release. > > There is no hurry to approve a release. > > In Apache we are primarily releasing the sources and the binaries are > provided only 'for convenience'. > > So users are expected to be able to run the tests and see them passing. > > I will give my final feedback tomorrow > > Enrico > > Il Gio 29 Lug 2021, 17:14 丛搏 <congbobo...@gmail.com> ha scritto: > >> Hi, >> I test again on my mac. >> environment: macOS. >> command: mvn clean install -am -pl pulsar-broker >> Most of the tests fail because the test has not been modified, only >> `org.apache.pulsar.broker.admin.TopicPoliciesTest.testRestart` run fail >> because ` https://github.com/apache/pulsar/pull/11294` >> <https://github.com/apache/pulsar/pull/11294> >> <https://github.com/apache/pulsar/pull/11294> don't have cherry-pick to >> branch-2.7. I suggest moving it to 2.7.4 to fix. Because it is not a newly >> introduced problem, but an existing problem. >> >> Thanks! >> Bo >> >> >> Enrico Olivelli <eolive...@gmail.com> 于2021年7月28日周三 下午2:03写道： >> >> > Il giorno mer 28 lug 2021 alle ore 06:36 丛搏 <congbobo...@gmail.com> ha >> > scritto: >> > >> > > Hi >> > > Is it a blocker of 2.7.3 release? If not, we can release first, and >> then >> > > solve this problem later. >> > > >> > >> > If tests are not passing then maybe something is broken. >> > I am not talking about a "flaky test" but something that is blocking the >> > machine. >> > >> > for instance recently (a couple of weeks ago), while running the tests >> on >> > branch-2.7 I found that delayed delivery was totally broken >> > https://github.com/apache/pulsar/pull/11374 >> > >> > unfortunately we are cherry-picking commits to branch-2.7 without >> > validating the patch against CI so every cherry-pick, especially the >> ones >> > which do not apply cleanly >> > may break the stability of the system >> > >> > I suggest to investigate the problem, and hopefully qualify it as "not a >> > problem", before closing the VOTE >> > >> > Pulsar is becoming more and more popular, we must not release something >> > that we are not sure that cannot be validated. >> > Unfortunately on 2.7 there are still many flaky tests, but AFAIK the >> test >> > suite used to eventually pass >> > >> > Enrico >> > >> > >> > > >> > > Thanks, >> > > Bo >> > > >> > > Enrico Olivelli <eolive...@gmail.com> 于2021年7月26日周一 下午10:55写道： >> > > >> > > > Hi, >> > > > are you able to run the tests from the source packages ? >> > > > If I run the pulsar-broker test at a certain point (I am still not >> able >> > > to >> > > > see where) my machines starts to use 100% CPU and it is blocked and >> I >> > > need >> > > > to reboot >> > > > >> > > > >> > > > Enrico >> > > > >> > > > Il giorno lun 26 lug 2021 alle ore 09:37 Nozomi Kurihara < >> > > > nkuri...@apache.org> ha scritto: >> > > > >> > > > > +1 (binding) >> > > > > >> > > > > - check signatures/checksums >> > > > > - compile the source >> > > > > - standalone/producer/consumer worked >> > > > > - function/cassandra-connector worked >> > > > > >> > > > > Best Regards, >> > > > > Nozomi >> > > > > >> > > > > 2021年7月26日(月) 16:07 Masahiro Sakamoto <massa...@yahoo-corp.jp>: >> > > > > >> > > > > > +1 (binding) >> > > > > > >> > > > > > - Checked checksums and signatures >> > > > > > - Compiled the source >> > > > > > - Ran the standalone server >> > > > > > - Confirmed that producer and consumer work properly >> > > > > > - Confirmed that the sample function works properly >> > > > > > >> > > > > > Regards, >> > > > > > >> > > > > > Masahiro Sakamoto >> > > > > > Yahoo Japan Corp. >> > > > > > E-mail: massa...@yahoo-corp.jp >> > > > > > >> > > > > > -----Original Message----- >> > > > > > From: 丛搏 <bog...@apache.org> >> > > > > > Sent: Wednesday, July 21, 2021 9:00 PM >> > > > > > To: dev@pulsar.apache.org >> > > > > > Subject: [VOTE] Pulsar Release 2.7.3 Candidate 2 >> > > > > > >> > > > > > This is the second release candidate for Apache Pulsar, version >> > > 2.7.3. >> > > > > > >> > > > > > It fixes the following issues: >> > > > > > >> > > > > > >> > > > > >> > > > >> > > >> > >> https://github.com/apache/pulsar/pulls?q=is%3Apr+is%3Aopen+label%3Arelease%2F2.7.3+is%3Apr+ >> > > > > > >> > > > > > *** Please download, test and vote on this release. This vote >> will >> > > stay >> > > > > > open >> > > > > > for at least 72 hours *** >> > > > > > >> > > > > > Note that we are voting upon the source (tag), binaries are >> > provided >> > > > for >> > > > > > convenience. >> > > > > > >> > > > > > Source and binary files: >> > > > > > >> > > > >> > https://dist.apache.org/repos/dist/dev/pulsar/pulsar-2.7.3-candidate-2/ >> > > > > > >> > > > > > SHA-512 checksums: >> > > > > > >> > > > > > >> > > > > > >> > > > > >> > > > >> > > >> > >> 323e896bebb2981cc99178e9584273908d5fd9427fa8e907027e8b7c59946cb04a3821af0e70b1a29b0ba166120c493a432fd4d5920e71ccef11e4095f5f30c6 >> > > > > > apache-pulsar-2.7.3-bin.tar.gz >> > > > > > >> > > > > > >> > > > > > >> > > > > >> > > > >> > > >> > >> 4eb2ff4a058fc5f0c0f1352aff926e6125c833c509901a16f93a118540a79a1fc575225b224f1f8ab7ff77c5aeea2a20fe8fedea1717ea249c27c9bbfbb4aae8 >> > > > > > apache-pulsar-2.7.3-src.tar.gz >> > > > > > >> > > > > > Maven staging repo: >> > > > > > >> > > > >> > >> https://repository.apache.org/content/repositories/orgapachepulsar-1093/ >> > > > > > >> > > > > > The tag to be voted upon: >> > > > > > v2.7.3-candidate-2 (d6c2667ea05339efd8aabf56fe667835b4fe76e9) >> > > > > > >> https://github.com/apache/pulsar/releases/tag/v2.7.3-candidate-2 >> > > > > > >> > > > > > Pulsar's KEYS file containing PGP keys we use to sign the >> release: >> > > > > > https://dist.apache.org/repos/dist/dev/pulsar/KEYS >> > > > > > >> > > > > > Please download the the source package, and follow the README to >> > > build >> > > > > > and run the Pulsar standalone service. >> > > > > > >> > > > > >> > > > >> > > >> > >> >
