RobertIndie edited a comment on pull request #83: URL: https://github.com/apache/pulsar-dotpulsar/pull/83#issuecomment-886320738
> so I was a bit worried about the interactions with batching, so I've added two integration tests where I attempt to create a scenario where this functionality is tested: > > https://github.com/apache/pulsar-dotpulsar/blob/e7df3a528e1dd948cd1ec23a5baa51d693fac34f/tests/DotPulsar.IntegrationTests/ConsumerTests.cs#L225-L226 > > Looking at the other PR's and the still open issue #7, am I fooling myself that this tests actually batches the messages and that at the moment there is actually no way (yet) to produce messages in a batched way using dotpulsar? That would make testing this particular behaviour tricky. I'd need to rely on deep(er) knowledge of the workings of batching to implement the right handling for this. Thanks for your PR. Currently, dotpulsar does not yet support batch sending. The code in your test isn't the correct batched way. Can we handle this scenario after the batch support is added? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
