Any other vote please ? We need at least one more +1 from a PMC member
Thanks Enrico Il giorno ven 2 lug 2021 alle ore 01:24 Rajan Dhabalia <rdhaba...@apache.org> ha scritto: > Sure, let's fix it as a part of the 2.9.0 release to build an adapter repo > without building pulsar locally. > > +1 for me. > - Validated signature and src code build. > > Thanks, > Rajan > > On Thu, Jul 1, 2021 at 1:43 PM Enrico Olivelli <eolive...@gmail.com> > wrote: > > > Rajan, > > Thanks for testing probably the instructions are not clear, see my > answers > > below > > > > Il Gio 1 Lug 2021, 21:27 Rajan Dhabalia <rdhaba...@apache.org> ha > scritto: > > > > > Hi, > > > > > > Right now, Build is failing with the below error which prevents us from > > > building the project with all test execution. README page also suggests > > to > > > build project by skipping tests (using -DskipTests options) > > > > > > > The skip tests flag is to build Pulsar from > > https://github.com/apache/pulsar > > at tag v2.8.0 > > Not to build the pulsar-adapters repo. > > > > This is because the integration tests jar is not deployed to Maven > Central > > as you can see in the error you posted. > > > > > > > [ERROR] Failed to execute goal on project > > > pulsar-kafka-compat-client-test: Could not resolve dependencies for > > > project > > org.apache.pulsar.tests:pulsar-kafka-compat-client-test:jar:2.8.0: > > > Failure to find org.apache.pulsar.tests:integration:jar:tests:2.8.0 > > > > > > I think we should fix the build failure or disable the test module if > > it's > > > not correctly migrated from the Pulsar git-repository, rather than > > > releasing and validating release with -DskipTests option. > > > > > > > The tests are all passing and this is confirmed by the fact that the > latest > > PRs were validated in CI. > > > > During the past month we enabled CI and we fixed all the tests > > > > Can you try to build locally Pulsar at tag v2.8.0? > > This way your maven local repository will contain the jar that is missing > > > > It is something we can fix for the the Pulsar release, but for 2.8.0 > there > > is no other way. > > > > Enrico > > > > > > > Thanks, > > > Rajan > > > > > > > > > > > > > > > On Tue, Jun 29, 2021 at 3:27 AM PengHui Li <peng...@apache.org> wrote: > > > > > > > Hi Enrico, > > > > sorry for the late reply > > > > > > > > 1. Checked the signature > > > > 2. Build via the source code > > > > 3. Passed all the tests locally > > > > > > > > The only one I found is when I unzip the package, it shows me an > > > > apache-pulsar-2.8.0-src directory, > > > > Looks a little wired, I think it should be > > > > apache-pulsar-adaptors-2.8.0-src? > > > > > > > > Thanks, > > > > Penghui > > > > > > > > Enrico Olivelli <eolive...@gmail.com> 于2021年6月29日周二 下午1:55写道： > > > > > > > > > Hi everyone, > > > > > please take a look. > > > > > If you want to build the source package locally you have to follow > > the > > > > > steps in the README > > > > > https://github.com/apache/pulsar-adapters > > > > > > > > > > Enrico > > > > > > > > > > Il giorno sab 26 giu 2021 alle ore 13:51 Enrico Olivelli < > > > > > eolive...@gmail.com> ha scritto: > > > > > > > > > > > This is the first release candidate for Apache Pulsar Adapters, > > > version > > > > > > 2.8.0. > > > > > > > > > > > > It fixes the following issues: > > > > > > https://github.com/apache/pulsar-adapters/milestone/2?closed=1 > > > > > > > > > > > > *** Please download, test and vote on this release. This vote > will > > > stay > > > > > > open > > > > > > for at least 72 hours *** > > > > > > > > > > > > Note that we are voting upon the source (tag), binaries are > > provided > > > > for > > > > > > convenience and are released only to Maven Central. > > > > > > > > > > > > Source and binary files: > > > > > > > > > > > > > > > > > > > > > > > > > > > https://dist.apache.org/repos/dist/dev/pulsar/pulsar-adapters-2.8.0-candidate-1/ > > > > > > > > > > > > SHA-512 checksums: > > > > > > > > > > > > > > > > > > > > > > > > > > > 6f1f34fc454fdaa9b5065d0dce96d468d8b5081cff333564cb88dca7e9c9aba828bb7469bb8c3aa4d23fe653d1a03285418d9ba36d5617a39a783e0433d01dba > > > > > > apache-pulsar-adapters-2.8.0-src.tar.gz > > > > > > > > > > > > Maven staging repo: > > > > > > > > > > > > https://repository.apache.org/content/repositories/orgapachepulsar-1091/ > > > > > > > > > > > > The tag to be voted upon: > > > > > > v2.8.0-candidate-1 (581fee3b68caaf74122e7051e9741494b57fcbd7) > > > > > > > > > > > > > > > > > > > > > https://github.com/apache/pulsar-adapters/releases/tag/v2.8.0-candidate-1 > > > > > > > > > > > > Pulsar's KEYS file containing PGP keys we use to sign the > release: > > > > > > https://dist.apache.org/repos/dist/dev/pulsar/KEYS > > > > > > > > > > > > Please download the source package, and follow the README to > build > > > the > > > > > > Pulsar Adapters code > > > > > > > > > > > > Enrico Olivelli > > > > > > > > > > > > > > > > > > > > >
