eolivelli commented on a change in pull request #14:
URL: https://github.com/apache/pulsar-adapters/pull/14#discussion_r654833418
##########
File path:
pulsar-spark/src/main/java/org/apache/pulsar/spark/SparkStreamingPulsarReceiver.java
##########
@@ -22,13 +22,12 @@
import static com.google.common.base.Preconditions.checkNotNull;
import java.io.Serializable;
+import java.util.HashMap;
+import java.util.Map;
-import org.apache.pulsar.client.api.Authentication;
-import org.apache.pulsar.client.api.Consumer;
-import org.apache.pulsar.client.api.MessageListener;
-import org.apache.pulsar.client.api.PulsarClient;
-import org.apache.pulsar.client.api.PulsarClientException;
+import org.apache.pulsar.client.api.*;
Review comment:
Please do not use star import.
##########
File path:
tests/pulsar-kafka-compat-client-test/src/test/java/org/apache/pulsar/tests/integration/compat/kafka/PulsarKafkaProducerThreadSafeTest.java
##########
@@ -37,8 +36,8 @@ private String getPlainTextServiceUrl() {
return container.getPlainTextServiceUrl();
}
- @Override
- public void setUpCluster() throws Exception {
+ @BeforeTest
+ private void setupThreadSafeTest() {
Review comment:
This change is unrelated can you please revert?
Cc @dlg99 @lhotari
##########
File path:
pulsar-flink/src/test/java/org/apache/flink/streaming/connectors/pulsar/PulsarConsumerSourceTests.java
##########
@@ -57,6 +57,7 @@
import java.util.concurrent.ConcurrentHashMap;
import java.util.concurrent.TimeUnit;
import java.util.concurrent.atomic.AtomicInteger;
+import java.util.function.Function;
Review comment:
This change probably not needed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
