MMeent opened a new pull request #118: URL: https://github.com/apache/pulsar-helm-chart/pull/118
This also limits the scope of the PodMonitors to the resources of only this install, instead of all installs that share `component:` label values. Fixes some issues with overly broad PodMonitor selectors, and put all selectors (except affinity selectors) in one line w.r.t. how they are generated. ### Motivation This chart has several templates for generating standardized labels, which can be overridden by the user for using their own label scheme. Due to inconsistently applied labelSelector templates, this is only partially viable. By consistently applying the `pulsar.matchLabels` template, this makes the chart more extendable, and by extension, more useable. Additionally, PodMonitor resources specified an overly broad scope for monitoring components of the chart, where it would e.g. watch all `component: bookie` pods, even those not generated by this chart. This is also fixed with this pull request. ### Modifications I've updated all labelSelector: -elements that I could find to use `pulsar.matchLabels` instead of hardcoded app + release labels. Additionally, I've narrowed the scope of the various PodMonitor resources to only watch resources that should have been generated by this release, such that a PodMonitor for this chart does not also monitor another chart (as that would be extra load on the servers). ### Verifying this change - [ ] Make sure that the change passes the CI checks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
