dlg99 opened a new pull request #9:
URL: https://github.com/apache/pulsar-adapters/pull/9
<!--
### Contribution Checklist
- Name the pull request in the form "[Issue XYZ][component] Title of the
pull request", where *XYZ* should be replaced by the actual issue number.
Skip *Issue XYZ* if there is no associated github issue for this pull
request.
Skip *component* if you are unsure about which is the best component.
E.g. `[docs] Fix typo in produce method`.
- Fill out the template below to describe the changes contributed by the
pull request. That will give reviewers the context they need to do the review.
- Each pull request should address only one issue, not mix up code from
multiple issues.
- Each commit in the pull request has a meaningful commit message
- Once all items of the checklist are addressed, remove the above text and
this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
*(If this PR fixes a github issue, please add `Fixes #<xyz>`.)*
Fixes #5
### Motivation
Tried building pulsar-adaptors locally with 2.8.0-SNAPSHOT.
Build failed.
Tried building with pulsar 2.7.1 release
Build fails.
Last pulsar-adaptors released with 2.6.x.
Some tests won't compile even with 2.7.1 release.
### Modifications
Made it build with locally built pulsar 2.8.0-SNAPSHOT (build as `mvn clean
install -DskipTests`)
Updated pom files to include dependencies that project needed, same versions
as pulsar IIRC.
Fixed tests that failed after all that (due to changes in pulsar).
One test needs fix in the pulsar, PR tbd, change is
```
diff --git
a/pulsar-client/src/main/java/org/apache/pulsar/client/impl/conf/ClientConfigurationData.java
b/pulsar-client/src/main/java/org/apache/pulsar/client/impl/conf/ClientConfigurationData.java
index 4a3091bbad4..fd1d5a092df 100644
---
a/pulsar-client/src/main/java/org/apache/pulsar/client/impl/conf/ClientConfigurationData.java
+++
b/pulsar-client/src/main/java/org/apache/pulsar/client/impl/conf/ClientConfigurationData.java
@@ -24,6 +24,7 @@ import java.time.Clock;
import java.util.Set;
import lombok.AllArgsConstructor;
import lombok.Data;
+import lombok.EqualsAndHashCode;
import lombok.NoArgsConstructor;
import org.apache.pulsar.client.api.Authentication;
import org.apache.pulsar.client.api.ProxyProtocol;
@@ -46,9 +47,11 @@ public class ClientConfigurationData implements
Serializable, Cloneable {
private String serviceUrl;
@JsonIgnore
+ @EqualsAndHashCode.Exclude
private transient ServiceUrlProvider serviceUrlProvider;
@JsonIgnore
+ @EqualsAndHashCode.Exclude
private Authentication authentication;
private String authPluginClassName;
@@ -102,6 +105,7 @@ public class ClientConfigurationData implements
Serializable, Cloneable {
private boolean enableTransaction = false;
@JsonIgnore
+ @EqualsAndHashCode.Exclude
private Clock clock = Clock.systemDefaultZone();
public Authentication getAuthentication() {
```
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
This change is already covered by existing tests, such as *(please describe
tests)*.
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): (probably, should
match pulsar's)
### Documentation
- Does this pull request introduce a new feature? (no)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
