patricklucas opened a new issue #374:
URL: https://github.com/apache/pulsar-manager/issues/374


   As described in apache/pulsar#9700, triggering an offload from 
pulsar-manager fails because it does not include the mandatory `messageId` 
parameter, which must be determined on the client before making the request, in 
the PUT request to initiate an offload operation on a topic.
   
   In apache/pulsar#9737 (to be included in Pulsar 2.7.1), validation was added 
to validate and reject a missing `messageId` parameter. In 2.7.0, triggering an 
offload operation via pulsar-manager or the REST API caused an NPE and resulted 
in the topic being stuck with an offload operation in progress.
   
   The Pulsar admin client [determines the correct 
`messageId`](https://github.com/apache/pulsar/blob/v2.7.0/pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdTopics.java#L889-L901)
 based on a provided size threshold—does something similar need to be added to 
pulsar-manager?
   
   I wonder if it would be best to move this logic into Pulsar itself, where 
instead of providing a `messageId` to offload earlier messages than, providing 
the "size threshold" and letting Pulsar do the logic itself.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to