Thanks for the proposal Enrico.


On Mon, Feb 8, 2021 at 12:32 PM Enrico Olivelli <eolive...@gmail.com> wrote:

> 2) Building Pulsar and running Tests
> We can require Pulsar to be built on JDK11.
> We can set maven.compiler.release to 11 in generale and
> maven.compiler.release to 8 for all of the modules that concur to build up
> the Java client
> Tests will run on JDK11 on CI.
> We could desire to run the Pulsar client tests on JDK8, but many of them
> are indeed inside the pulsar-broker module.
>
>
I have an experiment for this running in
https://github.com/lhotari/pulsar/pull/6 . That's some work I made earlier
as an attempt to fix https://github.com/apache/pulsar/issues/8445 .

The `--release 8` flag has some challenges with sun.management.* classes,
for example I get an error message

[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-compiler-plugin:3.8.1:compile
(default-compile) on project pulsar-common: Compilation failure
[ERROR]
/home/lari/workspace-pulsar/pulsar/pulsar-common/src/main/java/org/apache/pulsar/common/stats/JvmDefaultGCMetricsLogger.java:[40,34]
package sun.management does not exist

It fails at least at this location:
https://github.com/apache/pulsar/blob/master/pulsar-common/src/main/java/org/apache/pulsar/common/stats/JvmDefaultGCMetricsLogger.java#L46

Making the code fully JDK 11 & `--release 8` flag compatible requires some
effort.

-Lari

Reply via email to