massakam commented on a change in pull request #138:
URL: https://github.com/apache/pulsar-client-node/pull/138#discussion_r559973025
##########
File path: src/ProducerConfig.cc
##########
@@ -153,6 +162,25 @@ ProducerConfig::ProducerConfig(const Napi::Object&
producerConfig) : topic("") {
value.Utf8Value().c_str());
}
}
+
+ if ((producerConfig.Has(CFG_PUBLIC_KEY_PATH) &&
producerConfig.Has(CFG_PRIVATE_KEY_PATH)) &&
Review comment:
On the producer side, a private key does not seem to be required.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
