Thanks Enrico.
Penghui On Nov 25, 2020, 9:58 PM +0800, Enrico Olivelli <eolive...@gmail.com>, wrote: > Il giorno mer 25 nov 2020 alle ore 14:18 PengHui Li <codelipeng...@gmail.com> > ha scritto: > > > Thanks Enrico, > > > > Could you please also help create an issue for the PrometheusMetricsTest? > > > > Sure, > this is a pull request with a fix > https://github.com/apache/pulsar/pull/8702 > > The problem is more about PulsarVersion, in which the ${git.commit.id} > placeholder is not replaced. > The problem affects who is building Pulsar from sources out of a > git repository, probably it is not a big deal. > > Best regards > Enrico > > > > > We can fix it in the next release version. > > > > Thanks, > > Penghui > > On Nov 25, 2020, 9:06 PM +0800, Enrico Olivelli <eolive...@gmail.com>, > > wrote: > > > +0 (non-binding) > > > > > > - verified checksums and sigs > > > - run smoke tests on the binary tarball > > > - built from sources and run "pulsar standalone" from the resulting > > binaries > > > - built on Mac and on Fedora, with JDK8 (AdoptOpenJDK) > > > > > > My vote is not a full +1 because if I run the sources there is a > > > non-transient error on PrometheusMetricsTest > > > it is constantly failing because at line 568 we are trying to parse a > > line > > > like this: > > > pulsar_version_info{cluster="test",version="2.7.0",commit="${ > > git.commit.id > > > }"} > > > that means that the ${git.commit.id} is not replaced correctly > > > > > > I also had problems on the Fedora machine with the tests about Pulsar > > > Functions, I had to install minikube, I have reported an issue > > > > > > btw this is a great release ! > > > > > > Enrico > > > > > > > > > Il giorno mer 25 nov 2020 alle ore 10:50 Shusuke Tsuda < > > > shust...@yahoo-corp.jp> ha scritto: > > > > > > > +1 (non-binding) > > > > > > > > - check signatures/checksums > > > > - compile the source > > > > - standalone/producer/consumer worked > > > > > > > > Thanks, > > > > Shusuke Tsuda > > > > > > > > -----Original Message----- > > > > From: PengHui Li <peng...@apache.org> > > > > Sent: Monday, November 23, 2020 9:32 AM > > > > To: Dev <dev@pulsar.apache.org> > > > > Subject: [VOTE] Pulsar Release 2.7.0 Candidate 1 > > > > > > > > This is the first release candidate for Apache Pulsar, version 2.7.0. > > > > > > > > It fixes the following > > > > issues:https://github.com/apache/pulsar/milestone/28?closed=1 > > > > > > > > *** Please download, test and vote on this release. This vote will stay > > > > open for at least 72 hours *** > > > > > > > > Note that we are voting upon the source (tag), binaries are provided > > for > > > > convenience. > > > > > > > > Source and binary > > > > files: > > > > > > https://dist.apache.org/repos/dist/dev/pulsar/pulsar-2.7.0-candidate-1/ > > > > > > > > SHA-1 checksums: > > > > > > > > dd30d80a7c2e51380e12d45c2dffbcd4ff751981 apache-pulsar-2.7.0-bin.tar.gz > > > > bf5a674fb74d3b569e575942fb42e2c0661a5497 apache-pulsar-2.7.0-src.tar.gz > > > > > > > > Maven staging repo: > > > > > > https://repository.apache.org/content/repositories/orgapachepulsar-1073/ > > > > > > > > The tag to be voted upon: > > > > v2.7.0-candidate-1 > > > > (72b9f5d96ca19c358afd83952eed7ab7ebe61e5d) > > > > https://github.com/apache/pulsar/releases/tag/v2.7.0-candidate-1 > > > > > > > > Pulsar's KEYS file containing PGP keys we use to sign the release: > > > > https://dist.apache.org/repos/dist/release/pulsar/KEYS > > > > > > > > Please download the the source package, and follow the README to build > > and > > > > run the Pulsar standalone service. > > > > > >
